Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocDB] Mark YBSession Flush sync functions as test-only #12165

Closed
ttyusupov opened this issue Apr 14, 2022 · 0 comments
Closed

[DocDB] Mark YBSession Flush sync functions as test-only #12165

ttyusupov opened this issue Apr 14, 2022 · 0 comments
Assignees
@ttyusupov
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
YBase features Technical investments

Comments

@ttyusupov
Copy link
Contributor

ttyusupov commented Apr 14, 2022 •
edited by jira bot

Jira Link: DB-8247

Description

Synchronously blocking on YBSession flush in production code could lead to issues in case of high load. Async versions should be used instead.
@ttyusupov ttyusupov added kind/enhancement This is an enhancement of an existing feature area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Apr 14, 2022
@ttyusupov ttyusupov self-assigned this Apr 14, 2022
@ttyusupov ttyusupov added this to To do in Technical investments via automation Apr 14, 2022
@ttyusupov ttyusupov added this to Backlog in YBase features via automation Apr 14, 2022
@ttyusupov ttyusupov moved this from To do to In progress in Technical investments Apr 14, 2022
@ttyusupov ttyusupov moved this from Backlog to In progress in YBase features Apr 14, 2022
@ttyusupov ttyusupov mentioned this issue Apr 14, 2022
Open
ttyusupov added a commit that referenced this issue Apr 15, 2022
@ttyusupov
[#12165] docdb: marked sync functions for YBSession flush as test only
ec1d929 
Summary:
Synchronously blocking on YBSession flush in production code could lead to issues in case of high load. Async versions should be used instead.

Marked sync functions for YBSession flush as test only by renaming them to `YBSession::TEST_*`.

Test Plan: Jenkins

Reviewers: bogdan

Reviewed By: bogdan

Subscribers: rahuldesirazu, nicolas, jhe, slingam, sergei, bogdan

Differential Revision: https://phabricator.dev.yugabyte.com/D16553
YBase features automation moved this from In progress to Done Apr 15, 2022
Technical investments automation moved this from In progress to Done Apr 15, 2022
hari90 added a commit that referenced this issue Sep 28, 2023
@hari90
[#12165] DocDB: Mark YBSession Flush sync functions as test-only
842d0b3 
Summary:
Synchronously blocking on YBSession flush in production code could lead to issues in case of high load. Async versions should be used instead (FlushAsync).

Sync functions for YBSession flush have been renamed to TEST_*. `TEST_ReadSync` has been replaced with `TEST_ApplyAndFlush`

`TODO(async_flush): #12173 has been added to all production code paths that call the sync Flush functions.

Test Plan: All yb tests

Reviewers: timur, bogdan, xCluster

Reviewed By: timur

Subscribers: yql, ybase, ycdcxcluster

Differential Revision: https://phorge.dev.yugabyte.com/D28735
@rthallamko3 rthallamko3 removed the status/awaiting-triage Issue awaiting triage label Oct 9, 2023
@yugabyte-ci yugabyte-ci added the priority/medium Medium priority issue label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ttyusupov ttyusupov

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
Technical investments
  
Done
YBase features
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ttyusupov @rthallamko3 @yugabyte-ci