Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocDB] Increase default for retryable_request_timeout_secs to 660 seconds #13195

Closed
ttyusupov opened this issue Jul 7, 2022 · 0 comments
Closed

[DocDB] Increase default for retryable_request_timeout_secs to 660 seconds #13195

ttyusupov opened this issue Jul 7, 2022 · 0 comments
Assignees
@ttyusupov
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/high High Priority
Projects
YBase features

Comments

@ttyusupov
Copy link
Contributor

ttyusupov commented Jul 7, 2022 •
edited by bmatican
Loading

Jira Link: DB-2873

Description

This is a short-term solution for #13171
@ttyusupov ttyusupov added kind/bug This issue is a bug area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Jul 7, 2022
@ttyusupov ttyusupov self-assigned this Jul 7, 2022
@yugabyte-ci yugabyte-ci added the priority/medium Medium priority issue label Jul 7, 2022
@ttyusupov ttyusupov added this to Backlog in YBase features via automation Jul 7, 2022
@ttyusupov ttyusupov added priority/high High Priority and removed priority/medium Medium priority issue labels Jul 7, 2022
@yugabyte-ci yugabyte-ci removed the status/awaiting-triage Issue awaiting triage label Jul 7, 2022
ttyusupov added a commit that referenced this issue Jul 8, 2022
@ttyusupov
[#13195] docdb: Increased retryable_request_timeout_secs to 660 seconds
413edd0 
Summary:
`retryable_request_timeout_secs` should be larger than YQL request timeout to avoid consistency issues like #537.
Separate `ysql_client_read_write_timeout_ms` flag was introduced for YSQL and by default it bumps up `YBClient` timeout to 600 seconds: 2294c84.
Hence we need to bump `retryable_request_timeout_secs` to a larger value.

Test Plan: Jenkins

Reviewers: bogdan, amitanand

Reviewed By: bogdan, amitanand

Subscribers: amitanand, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D18171
amitanandaiyer pushed a commit that referenced this issue Jul 8, 2022
@ttyusupov @amitanandaiyer
[BACKPORT 2.14][#13195] docdb: Increased retryable_request_timeout_se…
128021c 
…cs to 660 seconds

Summary:
`retryable_request_timeout_secs` should be larger than YQL request timeout to avoid consistency issues like #537.
Separate `ysql_client_read_write_timeout_ms` flag was introduced for YSQL and by default it bumps up `YBClient` timeout to 600 seconds: 2294c84.
Hence we need to bump `retryable_request_timeout_secs` to a larger value.

Original commit: D18171 / 413edd0

Test Plan: Jenkins: urgent

Reviewers: bogdan

Reviewed By: bogdan

Subscribers: amitanand, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D18219
amitanandaiyer pushed a commit that referenced this issue Jul 8, 2022
@ttyusupov @amitanandaiyer
[BACKPORT 2.12][#13195] docdb: Increased retryable_request_timeout_se…
30211e2 
…cs to 660 seconds

Summary:
`retryable_request_timeout_secs` should be larger than YQL request timeout to avoid consistency issues like #537.
Separate `ysql_client_read_write_timeout_ms` flag was introduced for YSQL and by default it bumps up `YBClient` timeout to 600 seconds: 2294c84.
Hence we need to bump `retryable_request_timeout_secs` to a larger value.

Original commit: D18171 / 413edd0

Test Plan: Jenkins

Reviewers: bogdan, amitanand

Reviewed By: amitanand

Subscribers: ybase, amitanand

Differential Revision: https://phabricator.dev.yugabyte.com/D18210
amitanandaiyer pushed a commit that referenced this issue Jul 9, 2022
@ttyusupov @amitanandaiyer
[BACKPORT 2.15.0][#13195] docdb: Increased retryable_request_timeout_…
148afaf 
…secs to 660 seconds

Summary:
`retryable_request_timeout_secs` should be larger than YQL request timeout to avoid consistency issues like #537.
Separate `ysql_client_read_write_timeout_ms` flag was introduced for YSQL and by default it bumps up `YBClient` timeout to 600 seconds: 2294c84.
Hence we need to bump `retryable_request_timeout_secs` to a larger value.

Original commit: D18171 / 413edd0

Test Plan: Jenkins: urgent

Reviewers: timur, bogdan

Reviewed By: bogdan

Subscribers: amitanand, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D18218
YBase features automation moved this from Backlog to Done Jul 9, 2022
ttyusupov added a commit that referenced this issue Jul 11, 2022
@ttyusupov
[BACKPORT 2.8][#13195] docdb: Increased retryable_request_timeout_sec…
cb0b7ee 
…s to 660 seconds

Summary:
`retryable_request_timeout_secs` should be larger than YQL request timeout to avoid consistency issues like #537.
Separate `ysql_client_read_write_timeout_ms` flag was introduced for YSQL and by default it bumps up `YBClient` timeout to 600 seconds: 2294c84.
Hence we need to bump `retryable_request_timeout_secs` to a larger value.

Original commit: D18171 / 413edd0

Test Plan: Jenkins: hot

Reviewers: bogdan, amitanand

Reviewed By: bogdan, amitanand

Subscribers: ybase, amitanand

Differential Revision: https://phabricator.dev.yugabyte.com/D18244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ttyusupov ttyusupov

Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/high High Priority
Projects
YBase features
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ttyusupov @yugabyte-ci