Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocDB] Better readable /mem-trackers ui #13592

Closed
amitanandaiyer opened this issue Aug 11, 2022 · 0 comments
Closed

[DocDB] Better readable /mem-trackers ui #13592

amitanandaiyer opened this issue Aug 11, 2022 · 0 comments
Assignees
@amitanandaiyer
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@amitanandaiyer
Copy link
Contributor

amitanandaiyer commented Aug 11, 2022 •
edited by yugabyte-ci

Jira Link: DB-3167

Description

current mem-trackers page is difficult to read.

using tracker->ToString() instead id() will print the path from the node to the root, so will be easy to parse/understand.
@amitanandaiyer amitanandaiyer added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Aug 11, 2022
@amitanandaiyer amitanandaiyer self-assigned this Aug 11, 2022
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue and removed status/awaiting-triage Issue awaiting triage labels Aug 11, 2022
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature and removed kind/bug This issue is a bug labels Sep 1, 2022
amitanandaiyer added a commit that referenced this issue Sep 15, 2022
@amitanandaiyer
[#13592] Docdb: Use tracker->ToString() instead of tracker->id() in /…
06b121c 
…mem-trackers

Summary:
/mem-trackers page is difficult to read. Using tracker->ToString() instead id() will print the path from the node to the root, and make it easy to understand.

For scripts/cases that may prefer the older format, we introduce a `show_full_path` URL parameter. One can get the old behavior by curling `/mem-trackers? show_full_path=false` instead.

Test Plan:
launch a local cluster, and check /mem-trackers

sample output:
```
server->root| 491.76M (579.41M)| 491.78M| none
Outbound RPC->Call->CQL->server->root| 0B| 0B| none
Compressed Read Buffer->CQL->server->root| 0B| 0B| none
Read Buffer->CQL->server->root| 0B| 0B| 483.50M
Outbound RPC->Read Buffer->CQL->server->root| 0B| 0B| none
Inbound RPC->Call->server->root| 0B| 7.2K| none
Outbound RPC->Call->server->root| 0B| 0B| none
Compressed Read Buffer->server->root| 0B (43.83M)| 0B| none
Receive->Compressed Read Buffer->server->root| 43.83M| 43.83M| none
Read Buffer->server->root| 0B (43.83M)| 52.6K| 483.50M
CQL->Read Buffer->server->root| 0B| 0B| none
Inbound RPC->Read Buffer->server->root| 0B (40.49M)| 17.7K| none
Reading->Inbound RPC->Read Buffer->server->root| 0B| 0B| none
Receive->Inbound RPC->Read Buffer->server->root| 40.49M| 40.49M| none
Sending->Inbound RPC->Read Buffer->server->root| 0B| 17.7K| none
Outbound RPC->Read Buffer->server->root| 0B (3.33M)| 52.6K| none
Queueing->Outbound RPC->Read Buffer->server->root| 0B| 7.8K| none
Reading->Outbound RPC->Read Buffer->server->root| 0B| 0B| none
Receive->Outbound RPC->Read Buffer->server->root| 3.33M| 3.33M| none
Sending->Outbound RPC->Read Buffer->server->root| 0B| 52.5K| none
Redis->Read Buffer->server->root| 0B| 0B| none
Allocated->Redis->Read Buffer->server->root| 0B| 0B| none
Mandatory->Redis->Read Buffer->server->root| 0B| 0B| none
Used->Redis->Read Buffer->server->root| 0B| 0B| none
Outbound RPC->Call->Redis->server->root| 0B| 0B| none
Read Buffer->Redis->server->root| 0B| 0B| 483.50M
Outbound RPC->Read Buffer->Redis->server->root| 0B| 0B| none
```

check `/mem-trackers? show_full_path=false` to ensure the display is in the old mode.

Reviewers: rsami, rthallam, bogdan

Reviewed By: bogdan

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D18891
@bmatican bmatican closed this as completed Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amitanandaiyer amitanandaiyer

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bmatican @yugabyte-ci @amitanandaiyer