Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL][Colocation] Abstract away colocation_id prefix from LRT layer #13733

Open
yugabyte-ci opened this issue Aug 23, 2022 · 0 comments
Open

[YSQL][Colocation] Abstract away colocation_id prefix from LRT layer #13733

yugabyte-ci opened this issue Aug 23, 2022 · 0 comments
Assignees
@hulien22
Labels
area/docdb YugabyteDB core features area/ysql Yugabyte SQL (YSQL) jira-originated kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@yugabyte-ci
Copy link
Contributor

yugabyte-ci commented Aug 23, 2022 •
edited by tverona1

Jira Link: DB-3262
This item is tracking the work to abstract away colocation_id prefix from LRT layer to reduce cross-functional implications and simplify decolocation design:

  • Have DocDB add colocation_id as needed as last step for read/write operations
  • LRT protobufs should look the same for colocated and non-colocated tables
  • Index ybbasectid (rowid reference to main table) would not have colocation_id
@yugabyte-ci yugabyte-ci added jira-originated kind/enhancement This is an enhancement of an existing feature priority/low Low priority status/awaiting-triage Issue awaiting triage labels Aug 23, 2022
@yugabyte-ci yugabyte-ci added priority/medium Medium priority issue and removed status/awaiting-triage Issue awaiting triage priority/low Low priority labels Aug 23, 2022
hulien22 added a commit that referenced this issue Nov 22, 2022
@hulien22
[#13733] docdb: Differentiate ybctid and dockey usage for colocation
c0e0034 
Summary: Currently dockeys and ybctids are used interchangeably in our code, which can be a bit confusing as there are some key differences. Notably, the main difference is that ybctids do not store any info about colocation ids or cotable ids. As part of simplifying colocation usage across ysql, this diff introduces a new `PgsqlYbctid` class that is just used for ybctids, and that has no references to colocation. Also introduces a `DocKeyBase` abstract class that both `PgsqlYbctid` and `DocKey` inherit from.

Test Plan: Jenkins

Reviewers: alex

Reviewed By: alex

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D19717
hulien22 added a commit that referenced this issue Dec 1, 2022
@hulien22
Revert "[#13733] docdb: Differentiate ybctid and dockey usage for col…
26f8fe7 
…ocation"

Summary: This reverts commit c0e0034.

Test Plan: n/a

Reviewers: alex, sergei, dmitry

Reviewed By: dmitry

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D21443
@frozenspider frozenspider changed the title Abstract away colocation_id prefix from LRT layer [YSQL][Colocation] Abstract away colocation_id prefix from LRT layer Dec 1, 2022
jayant07-yb pushed a commit to jayant07-yb/yugabyte-db that referenced this issue Dec 7, 2022
@hulien22
[yugabyte#13733] docdb: Differentiate ybctid and dockey usage for col…
f99f57f 
…ocation

Summary: Currently dockeys and ybctids are used interchangeably in our code, which can be a bit confusing as there are some key differences. Notably, the main difference is that ybctids do not store any info about colocation ids or cotable ids. As part of simplifying colocation usage across ysql, this diff introduces a new `PgsqlYbctid` class that is just used for ybctids, and that has no references to colocation. Also introduces a `DocKeyBase` abstract class that both `PgsqlYbctid` and `DocKey` inherit from.

Test Plan: Jenkins

Reviewers: alex

Reviewed By: alex

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D19717
jayant07-yb pushed a commit to jayant07-yb/yugabyte-db that referenced this issue Dec 7, 2022
@hulien22
Revert "[yugabyte#13733] docdb: Differentiate ybctid and dockey usage…
f0b184b 
… for colocation"

Summary: This reverts commit c0e0034.

Test Plan: n/a

Reviewers: alex, sergei, dmitry

Reviewed By: dmitry

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D21443
@rthallamko3 rthallamko3 added area/ysql Yugabyte SQL (YSQL) area/docdb YugabyteDB core features labels Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hulien22 hulien22

Labels
area/docdb YugabyteDB core features area/ysql Yugabyte SQL (YSQL) jira-originated kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rthallamko3 @yugabyte-ci @hulien22