Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocDB] Propagate new AutoFlags from master leader to tservers #14123

Closed
hari90 opened this issue Sep 21, 2022 · 0 comments
Closed

[DocDB] Propagate new AutoFlags from master leader to tservers #14123

hari90 opened this issue Sep 21, 2022 · 0 comments
Assignees
@hari90
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@hari90
Copy link
Contributor

hari90 commented Sep 21, 2022 •
edited by yugabyte-ci

Jira Link: DB-3604

Description

Propagate new AutoFlags config from master leader to tservers via hearbeat
@hari90 hari90 added kind/enhancement This is an enhancement of an existing feature area/docdb YugabyteDB core features labels Sep 21, 2022
@hari90 hari90 self-assigned this Sep 21, 2022
@yugabyte-ci yugabyte-ci added the priority/medium Medium priority issue label Sep 21, 2022
@hari90 hari90 mentioned this issue Sep 21, 2022
Closed
hari90 added a commit that referenced this issue Oct 6, 2022
@hari90
[#14122] DocDB: Propagate new AutoFlags from master leader to its peers
49c848a 
Summary:
Design: https://github.com/yugabyte/yugabyte-db/blob/master/architecture/design/auto_flags.md

Propagate AutoFlag config changes from master leader to its peers Sys_Catalog Tablet WAL. We cannot use sys catalog as we need this info at process startup, before rocksdb boot.
This is part of the AutoFlags Phase2 work which handles upgrades #12900

Added a new CHANGE_AUTO_FLAGS_CONFIG_OP operation type. DoReplicated will store the new AutoFlag config to the AutoFlags file and Apply it to the process.
It will be a no-op on non sys-catalog tablets. (#14123 handles propagation to tservers)
Added new PromoteAutoFlags RPC enable bumping the config version. This cannot yet be publicly used until other tasks in #12900 complete

Fixes #14122

Test Plan: AutoFlagsMiniClusterTest.Promote

Reviewers: bogdan, rahuldesirazu, rsami

Reviewed By: rsami

Subscribers: timur, ybase

Differential Revision: http://phabricator.dev.yugabyte.com/D19704
@hari90 hari90 closed this as completed in df4bc08 Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hari90 hari90

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hari90 @yugabyte-ci