Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDCSDK] Java level changes required in the API to create CDC stream #15067

Closed
vaibhav-yb opened this issue Nov 18, 2022 · 1 comment
Closed
Assignees
Labels
area/cdcsdk CDC SDK kind/bug This issue is a bug priority/medium Medium priority issue
Projects

Comments

@vaibhav-yb
Copy link
Contributor

vaibhav-yb commented Nov 18, 2022

Jira Link: DB-4292
The current implementation of CreateCDCStreamRequest in java does not take in the parameter record_type but if we want the API to create streams that have the before image support, we will need to make the changes in the API call so that it can be further used by the clients while writing tests.

@vaibhav-yb vaibhav-yb created this issue from a note in CDC (To do) Nov 18, 2022
@vaibhav-yb vaibhav-yb self-assigned this Nov 18, 2022
@vaibhav-yb vaibhav-yb added the area/cdcsdk CDC SDK label Nov 18, 2022
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Nov 18, 2022
@vaibhav-yb vaibhav-yb moved this from To do to In progress in CDC Nov 22, 2022
vaibhav-yb added a commit that referenced this issue Nov 25, 2022
…or before image

Summary:
This diff has the following changes:
* Modification for `CreateCDCStreamRequest` to also take another parameter which adds the `record_type` parameter so as to create streams with before image support. These changes will help in writing tests for verifying the before image support.
* Modification for the existing test framework a little so that the existing tests do not fail with the new changes.

Test Plan: Jenkins: java only

Reviewers: rvenkatesh, srangavajjula, skumar

Reviewed By: skumar

Subscribers: jenkins-bot, yugaware, ycdcxcluster

Differential Revision: https://phabricator.dev.yugabyte.com/D21277
vaibhav-yb added a commit that referenced this issue Nov 28, 2022
…te CDC stream for before image

Summary:
Original commit: 7cdc72d / D21277

This diff has the following changes:
* Modification for CreateCDCStreamRequest to also take another parameter which adds the record_type parameter so as to create streams with before image support. These changes will help in writing tests for verifying the before image support.
* Modification for the existing test framework a little so that the existing tests do not fail with the new changes.

Test Plan: Jenkins: java only

Reviewers: rvenkatesh, skumar

Reviewed By: skumar

Subscribers: ycdcxcluster, srangavajjula

Differential Revision: https://phabricator.dev.yugabyte.com/D21366
jayant07-yb pushed a commit to jayant07-yb/yugabyte-db that referenced this issue Dec 7, 2022
…stream for before image

Summary:
This diff has the following changes:
* Modification for `CreateCDCStreamRequest` to also take another parameter which adds the `record_type` parameter so as to create streams with before image support. These changes will help in writing tests for verifying the before image support.
* Modification for the existing test framework a little so that the existing tests do not fail with the new changes.

Test Plan: Jenkins: java only

Reviewers: rvenkatesh, srangavajjula, skumar

Reviewed By: skumar

Subscribers: jenkins-bot, yugaware, ycdcxcluster

Differential Revision: https://phabricator.dev.yugabyte.com/D21277
@vaibhav-yb
Copy link
Contributor Author

Closing this issue since the commit has been landed and backported.

CDC automation moved this from In progress to Done Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cdcsdk CDC SDK kind/bug This issue is a bug priority/medium Medium priority issue
Projects
CDC
  
Done
Development

No branches or pull requests

2 participants