Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CDCSDK] Upgrade to 2.16 causing issues with 'safe_time' #15384

Closed
adithya-kb opened this issue Dec 20, 2022 · 0 comments
Closed

[CDCSDK] Upgrade to 2.16 causing issues with 'safe_time' #15384

adithya-kb opened this issue Dec 20, 2022 · 0 comments
Assignees
@sureshdash2022-yb
Labels
area/cdcsdk CDC SDK kind/bug This issue is a bug priority/medium Medium priority issue
Projects
CDC

Comments

@adithya-kb
Copy link

adithya-kb commented Dec 20, 2022 •
edited by yugabyte-ci

Jira Link: DB-4515
In the method: PopulateTabletCheckPointInfo
We were previously erroring out prematurely in situations where 'safe_time' was not set. This meant the min checkpoints for each tablet would not be calculated , nor would we identify rows marked for deletion in the cdc_state table.
As a fix, we now do not error out on cases where the 'safe_time' is not set, rather we assume the safe time to be 'HybridTime::kInvalid' and move ahead.
@adithya-kb adithya-kb created this issue from a note in CDC (To do) Dec 20, 2022
@adithya-kb adithya-kb added 2.16.0_blocker 2.16.0 Release blocker defects area/cdcsdk CDC SDK labels Dec 20, 2022
@adithya-kb adithya-kb self-assigned this Dec 20, 2022
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Dec 20, 2022
@adithya-kb adithya-kb removed the 2.16.0_blocker 2.16.0 Release blocker defects label Dec 20, 2022
@adithya-kb adithya-kb moved this from To do to In progress in CDC Dec 20, 2022
adithya-kb pushed a commit that referenced this issue Dec 22, 2022
[#15384] CDCSDK: Ignore cases where safe_time not set in PopulateTabl…
3267352 
…etCheckPointInfo

Summary:
In the method: PopulateTabletCheckPointInfo
We were previously erroring out prematurely in situations where 'safe_time' was not set. This meant the min checkpoints for each tablet would not be calculated , nor would we identify rows marked for deletion in the cdc_state table.
As a fix, we now do not error out on cases where the 'safe_time' is not set, rather we assume the safe time to be 'HybridTime::kInvalid' and move ahead.

Test Plan: Added UT: TestBackwardCompatibillitySupportSafeTime

Reviewers: skumar, sdash

Reviewed By: sdash

Differential Revision: https://phabricator.dev.yugabyte.com/D21862
adithya-kb pushed a commit that referenced this issue Dec 22, 2022
[BACKPORT 2.16][#15384] CDCSDK: Ignore cases where safe_time not set …
26afd7a 
…in PopulateTabletCheckPointInfo

Summary:
Original commit: 3267352 / D21862
In the method: PopulateTabletCheckPointInfo
We were previously erroring out prematurely in situations where 'safe_time' was not set. This meant the min checkpoints for each tablet would not be calculated , nor would we identify rows marked for deletion in the cdc_state table.
As a fix, we now do not error out on cases where the 'safe_time' is not set, rather we assume the safe time to be 'HybridTime::kInvalid' and move ahead.

Test Plan: Added UT: TestBackwardCompatibillitySupportSafeTime

Reviewers: skumar, sdash

Reviewed By: sdash

Differential Revision: https://phabricator.dev.yugabyte.com/D21867
@adithya-kb adithya-kb moved this from In progress to Done in CDC Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sureshdash2022-yb sureshdash2022-yb

Labels
area/cdcsdk CDC SDK kind/bug This issue is a bug priority/medium Medium priority issue
Projects
CDC
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yugabyte-ci @adithya-kb @sureshdash2022-yb