Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not expose master table and tablet state too soon #1589

Open
bmatican opened this issue Jun 20, 2019 · 1 comment
Open

Do not expose master table and tablet state too soon #1589

bmatican opened this issue Jun 20, 2019 · 1 comment
Assignees
@lingamsandeep
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
YBase features Master components

Comments

@bmatican
Copy link
Contributor

bmatican commented Jun 20, 2019 •
edited by yugabyte-ci

Jira Link: DB-1442
There are a bunch of spots in the catalog manager code paths where we expose dirty state from the copy-on-write objects, before they are actually committed and valid.
@bmatican bmatican added kind/enhancement This is an enhancement of an existing feature area/docdb YugabyteDB core features master labels Jun 20, 2019
@bmatican bmatican self-assigned this Jun 20, 2019
@bmatican bmatican added this to To Do in YBase features via automation Jun 20, 2019
@bmatican bmatican added this to To do in Master components via automation Jun 20, 2019
bmatican added a commit that referenced this issue Jul 27, 2019
@bmatican
[#1589] PART1: Do not expose intermediate master state
fa85545 
Summary: Mostly a port from kudu of apache/kudu@f971971

Test Plan: Ported the relevant test as well and ran the master tests locally.

Reviewers: mikhail, sergei, mihnea, rahuldesirazu

Reviewed By: rahuldesirazu

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D6780
@yugabyte-ci yugabyte-ci added the priority/medium Medium priority issue label Jun 8, 2022
@bmatican
Copy link
Contributor Author

bmatican commented Jul 7, 2022

There was a 3-part series of diffs in Kudu around this. I previously managed to port in part 1 above
The other two were
apache/kudu@6e7a04a
apache/kudu@59ff89d

This would both help get rid of some table creation abortion code, as well as prevent some concurrent DDL races, eg: 2 create tables for same name

@bmatican bmatican assigned lingamsandeep and unassigned bmatican Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lingamsandeep lingamsandeep

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
Master components
  
To do
YBase features
  
Backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bmatican @rkarthik007 @yugabyte-ci @lingamsandeep