Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocDB] Use correct errno in log for failed mmap #16088

Closed
SrivastavaAnubhav opened this issue Feb 13, 2023 · 0 comments
Closed

[DocDB] Use correct errno in log for failed mmap #16088

SrivastavaAnubhav opened this issue Feb 13, 2023 · 0 comments
Assignees
@SrivastavaAnubhav
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue

Comments

@SrivastavaAnubhav
Copy link
Contributor

SrivastavaAnubhav commented Feb 13, 2023 •
edited by jira bot

Jira Link: DB-5481

Description

In the following error, we are printing the error code of the preceding ftruncate, instead of the mmap error code. We should print the mmap error code (set in errno).

F0210 20:12:55.941927  7683 [log.cc:908](http://log.cc:908/)] Check failed: _s.ok() Bad status: IO error (yb/consensus/log_index.cc:211): Couldn't open index chunk: Unable to mmap(): Success (system error 0)
@SrivastavaAnubhav SrivastavaAnubhav added area/docdb YugabyteDB core features priority/medium Medium priority issue labels Feb 13, 2023
@SrivastavaAnubhav SrivastavaAnubhav self-assigned this Feb 13, 2023
@yugabyte-ci yugabyte-ci added the kind/bug This issue is a bug label Feb 13, 2023
SrivastavaAnubhav added a commit that referenced this issue Feb 13, 2023
@SrivastavaAnubhav
[#16088] docdb: Use correct errno in log for failed mmap.
0c4cc51 
Summary: In the following error, we are printing the error code of the preceding ftruncate, instead of the mmap error code. We should print the mmap error code (set in errno).

Test Plan: Existing tests

Reviewers: bogdan

Reviewed By: bogdan

Subscribers: amitanand, timur, qhu, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D22909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SrivastavaAnubhav SrivastavaAnubhav

Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yugabyte-ci @SrivastavaAnubhav