Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CDCSDK] Flaky test: TestCDCLagMetric #16906

Closed
adithya-kb opened this issue Apr 18, 2023 · 0 comments
Closed

[CDCSDK] Flaky test: TestCDCLagMetric #16906

adithya-kb opened this issue Apr 18, 2023 · 0 comments
Assignees
@Sumukh-Phalgaonkar
Labels
area/cdcsdk CDC SDK kind/bug This issue is a bug kind/failing-test Tests and testing infra priority/medium Medium priority issue
Projects
CDC

Comments

@adithya-kb
Copy link

adithya-kb commented Apr 18, 2023 •
edited by jira bot

Jira Link: DB-6235
Fix flaky test: TestCDCLagMetric

http://detective.dev.yugabyte.com/stability/test?branch=master&class=CDCSDKYsqlTest&name=TestCDCLagMetric
@adithya-kb adithya-kb created this issue from a note in CDC (To do) Apr 18, 2023
@adithya-kb adithya-kb added the area/cdcsdk CDC SDK label Apr 18, 2023
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Apr 18, 2023
@adithya-kb adithya-kb added kind/failing-test Tests and testing infra and removed kind/bug This issue is a bug priority/medium Medium priority issue labels Apr 18, 2023
@adithya-kb adithya-kb self-assigned this Apr 18, 2023
@adithya-kb adithya-kb added the priority/medium Medium priority issue label Apr 18, 2023
adithya-kb pushed a commit that referenced this issue Apr 21, 2023
[#16906] CDCSDK: Fix falkyness of TestCDCLagMetric test
da12b47 
Summary:
The test was previosuly stricter around the lag metrics not being higher than 5.5 seconds, relaxing the constraint so that the lag metric is
just higher than 5 second (the induced lag from sleeping).

Test Plan: ./ybd --cxx-test cdcsdk_tablet_split-test --gtest_filter CDCSDKYsqlTest.TestCDCLagMetric

Reviewers: skumar

Reviewed By: skumar

Subscribers: ycdcxcluster

Differential Revision: https://phabricator.dev.yugabyte.com/D24564
omkaark pushed a commit to omkaark/yugabyte-db that referenced this issue Apr 21, 2023
@omkaark
[yugabyte#16906] CDCSDK: Fix falkyness of TestCDCLagMetric test
3a3ca07 
Summary:
The test was previosuly stricter around the lag metrics not being higher than 5.5 seconds, relaxing the constraint so that the lag metric is
just higher than 5 second (the induced lag from sleeping).

Test Plan: ./ybd --cxx-test cdcsdk_tablet_split-test --gtest_filter CDCSDKYsqlTest.TestCDCLagMetric

Reviewers: skumar

Reviewed By: skumar

Subscribers: ycdcxcluster

Differential Revision: https://phabricator.dev.yugabyte.com/D24564
@yugabyte-ci yugabyte-ci added the kind/bug This issue is a bug label Jul 24, 2023
Sumukh-Phalgaonkar added a commit that referenced this issue Jul 31, 2023
@Sumukh-Phalgaonkar
[#16906] CDCSDK: Removed the creation of second unused stream in the …
add5583 
…test CDCSDKYsqlTest.TestCDCLagMetric

Summary:
The unit test TestCDCLagMetric used to create two different streams. However, the second stream was never used after creation, hence removing it here.
Jira: DB-6235

Test Plan: ./yb_build.sh release --cxx-test integration-tests_cdcsdk_ysql-test --gtest_filter CDCSDKYsqlTest.TestCDCLagMetric --clang14

Reviewers: abharadwaj

Reviewed By: abharadwaj

Differential Revision: https://phorge.dev.yugabyte.com/D27397
CDC automation moved this from To do to Done Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sumukh-Phalgaonkar Sumukh-Phalgaonkar

Labels
area/cdcsdk CDC SDK kind/bug This issue is a bug kind/failing-test Tests and testing infra priority/medium Medium priority issue
Projects
CDC
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yugabyte-ci @adithya-kb @Sumukh-Phalgaonkar