Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CDCSDK] Add Begin/ Commit records to single shard transactions under a GFLAG #17312

Open
adithya-kb opened this issue May 12, 2023 · 0 comments
Open

[CDCSDK] Add Begin/ Commit records to single shard transactions under a GFLAG #17312

adithya-kb opened this issue May 12, 2023 · 0 comments
Projects
CDC

Comments

@adithya-kb
Copy link

No description provided.

@adithya-kb adithya-kb created this issue from a note in CDC (To do) May 12, 2023
adithya-kb pushed a commit that referenced this issue Jun 6, 2023
[#17312] CDCSDK: Add begin/commit records for single shard txns
6329729 
Summary:
We have introduced a new GFLAG: FLAGS_cdc_end_markers_for_single_shard_transactions , which is set to true (default value false),
will send BEGIN and COMMIT records for each single shard transaction.

Test Plan: ./ybd --cxx-test cdcsdk_tablet_split-test --gtest_filter CDCSDKYsqlTest.TestBeginAndCommitRecordsForSingleShardTxns

Reviewers: skumar, srangavajjula, rvenkatesh, vkushwaha

Reviewed By: vkushwaha

Subscribers: ycdcxcluster

Differential Revision: https://phorge.dev.yugabyte.com/D25287
@adithya-kb adithya-kb moved this from To do to Done in CDC Jun 13, 2023
adithya-kb pushed a commit that referenced this issue Jul 4, 2023
[BACKPORT 2.18][#17312] CDCSDK: Add begin/commit records for single s…
09969ee 
…hard txns

Summary:
Original commit: 6329729 / D25287
We have introduced a new GFLAG: FLAGS_cdc_populate_end_markers_transactions , which when set to true (default value true),
will send BEGIN and COMMIT records for each single shard / multi shard transaction.

Test Plan: ./ybd --cxx-test cdcsdk_tablet_split-test --gtest_filter CDCSDKYsqlTest.TestBeginAndCommitRecordsForSingleShardTxns

Reviewers: vkushwaha, skumar, aagrawal

Reviewed By: aagrawal

Subscribers: ycdcxcluster

Differential Revision: https://phorge.dev.yugabyte.com/D26635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
CDC
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adithya-kb