[DocDB] Add migration for namespace name field added in version 2.3.0 #17713
Assignees
Labels
2.14 Backport Required
2.16 Backport Required
2.18 Backport Required
area/docdb
YugabyteDB core features
kind/bug
This issue is a bug
priority/high
High Priority
Comments
karan-yb
added
area/docdb
yugabyte-ci
added
kind/bug
yugabyte-ci
added
priority/high
hulien22
added a commit
that referenced
this issue
Aug 9, 2023
Summary: The namespace_name field was introduced in 2.3 but we didn't do any migration for it. This has led to issues on newer versions where newer code expects that this field is present, causing issues with ycql system.partitions, snapshots, metrics. Using the master migration framework to migrate this field. As part of this, I have moved the namespace loader to be before the table loader (since that way we have the namespace info when loading tables). Note: We still need to migrate the TableInfo stored in Raft Superblocks as well, but that will be done in a later diff, after we finalize the design there. Jira: DB-6815 Test Plan: ``` ybd --cxx-test sys_catalog-test --gtest_filter SysCatalogTest.TestNamespaceNameMigration ybd --cxx-test yb-admin-snapshot-test --gtest_filter AdminCliTest.TestListSnapshotWithNamespaceNameMigration ``` Reviewers: hsunder, zdrudi, asrivastava, skedia Reviewed By: zdrudi, skedia Subscribers: yql, yguan, ybase, bogdan Differential Revision: https://phorge.dev.yugabyte.com/D27040
yugabyte-ci
added
kind/enhancement
yugabyte-ci
added
kind/bug
hulien22
added a commit
that referenced
this issue
Oct 21, 2023
…o namespace_name Summary: Original commit: 231d34a / D29340 The namespace_name field was introduced in 2.3 but we didn't do any migration for it. This has led to issues on newer versions where newer code expects that this field is present, causing issues with ycql system.partitions, snapshots, metrics. Using the master migration framework to migrate this field. As part of this, I have moved the namespace loader to be before the table loader (since that way we have the namespace info when loading tables). Note: We still need to migrate the TableInfo stored in Raft Superblocks as well, but that will be done in a later diff, after we finalize the design there. Jira: DB-6815 Test Plan: ``` ybd --cxx-test sys_catalog-test --gtest_filter SysCatalogTest.TestNamespaceNameMigration ybd --cxx-test yb-admin-test_ent --gtest_filter AdminCliTest.TestListSnapshotWithNamespaceNameMigration ``` Reviewers: hsunder, zdrudi, asrivastava, skedia Reviewed By: asrivastava Subscribers: bogdan, ybase, yguan, yql Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D29479
hulien22
added a commit
that referenced
this issue
Oct 24, 2023
…o namespace_name Summary: Original commit: 8afc03a / D27040 The namespace_name field was introduced in 2.3 but we didn't do any migration for it. This has led to issues on newer versions where newer code expects that this field is present, causing issues with ycql system.partitions, snapshots, metrics. Using the master migration framework to migrate this field. As part of this, I have moved the namespace loader to be before the table loader (since that way we have the namespace info when loading tables). Note: We still need to migrate the TableInfo stored in Raft Superblocks as well, but that will be done in a later diff, after we finalize the design there. Jira: DB-6815 Test Plan: ``` ybd --cxx-test sys_catalog-test --gtest_filter SysCatalogTest.TestNamespaceNameMigration ybd --cxx-test yb-admin-snapshot-test --gtest_filter AdminCliTest.TestListSnapshotWithNamespaceNameMigration ``` Reviewers: hsunder, zdrudi, asrivastava, skedia Reviewed By: zdrudi Subscribers: bogdan, ybase, yguan, yql Differential Revision: https://phorge.dev.yugabyte.com/D29173
hulien22
added a commit
that referenced
this issue
Oct 24, 2023
…o namespace_name Summary: Original commit: 8afc03a / D27040 The namespace_name field was introduced in 2.3 but we didn't do any migration for it. This has led to issues on newer versions where newer code expects that this field is present, causing issues with ycql system.partitions, snapshots, metrics. Using the master migration framework to migrate this field. As part of this, I have moved the namespace loader to be before the table loader (since that way we have the namespace info when loading tables). Note: We still need to migrate the TableInfo stored in Raft Superblocks as well, but that will be done in a later diff, after we finalize the design there. Jira: DB-6815 Test Plan: ``` ybd --cxx-test sys_catalog-test --gtest_filter SysCatalogTest.TestNamespaceNameMigration ybd --cxx-test yb-admin-test_ent --gtest_filter AdminCliTest.TestListSnapshotWithNamespaceNameMigration ``` Reviewers: hsunder, zdrudi, asrivastava, skedia Reviewed By: zdrudi Subscribers: yql, yguan, ybase, bogdan Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D29560
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira Link: DB-6815
Description
See details in #17712
Warning: Please confirm that this issue does not contain any sensitive information
The text was updated successfully, but these errors were encountered: