[DocDB] Histogram quantile p50/95/99 are not exported as gauge to Prometheus #TYPE #17868
Closed
1 task done
Assignees
Labels
2.18 Backport Required
area/docdb
YugabyteDB core features
kind/bug
This issue is a bug
priority/medium
Medium priority issue
Comments
yusong-yan
added
area/docdb
yugabyte-ci
added
kind/bug
yusong-yan
changed the title
yusong-yan
added a commit
that referenced
this issue
Jun 26, 2023
…etheus #TYPE Summary: Histogram quantile p50/95/99 should be exported as gauge, because as we reset the histogram, it gets computed based on ad-hoc latency values, so it can go up/down over time. Jira: DB-6952 Test Plan: Check Prometheus endpoint Reviewers: rthallam, jhe, amitanand Reviewed By: rthallam, amitanand Subscribers: bogdan, ybase Differential Revision: https://phorge.dev.yugabyte.com/D26343
yusong-yan
added a commit
that referenced
this issue
Jun 28, 2023
…s gauge to Prometheus #TYPE Summary: Original commit: 089aa04 / D26343 Histogram quantile p50/95/99 should be exported as gauge, because as we reset the histogram, it gets computed based on ad-hoc latency values, so it can go up/down over time. Jira: DB-6952 Test Plan: Check Prometheus endpoint Reviewers: rthallam, jhe, amitanand Reviewed By: rthallam Subscribers: ybase, bogdan Differential Revision: https://phorge.dev.yugabyte.com/D26450
dr0pdb
pushed a commit
to dr0pdb/yugabyte-db
that referenced
this issue
Jul 6, 2023
… to Prometheus #TYPE Summary: Histogram quantile p50/95/99 should be exported as gauge, because as we reset the histogram, it gets computed based on ad-hoc latency values, so it can go up/down over time. Jira: DB-6952 Test Plan: Check Prometheus endpoint Reviewers: rthallam, jhe, amitanand Reviewed By: rthallam, amitanand Subscribers: bogdan, ybase Differential Revision: https://phorge.dev.yugabyte.com/D26343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira Link: DB-6952
Description
After finishing #17016, the Prometheus endpoint now exports #HELP and #TYPE for each metric. For histogram quantile p50/95/99, it gets exported as counter to Prometheus #TYPE.
However, histogram quantile p50/95/99 #TYPE should be gauge, because as we reset the histogram, it gets computed based on ad-hoc latency values, so it can go up/down over time.
Warning: Please confirm that this issue does not contain any sensitive information
The text was updated successfully, but these errors were encountered: