New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YCQL] Incorrect TOJSON() output for nested UDT #18344
Labels
2.14 Backport Required
2.16 Backport Required
2.18 Backport Required
2.18.0_blocker
area/ycql
Yugabyte CQL (YCQL)
kind/bug
This issue is a bug
priority/medium
Medium priority issue
Projects
Comments
OlegLoginov
added
kind/bug
This issue is a bug
area/ycql
Yugabyte CQL (YCQL)
status/awaiting-triage
Issue awaiting triage
labels
Jul 20, 2023
Note that for the first level of nesting it works correctly:
Cassandra:
|
Note: The issue affects any |
OlegLoginov
added a commit
that referenced
this issue
Aug 7, 2023
Summary: Before the fix the `TOJSON()` implementation in DocDB did not unpack UDT if it's a field in a parent UDT (a nested UDT). Now it's fixed. The issue affects any `UDT< FROZEN<*> >` combinations - including `UDT< FROZEN<UDT> >`, `UDT< FROZEN<LIST> >`, `UDT< FROZEN<SET> >` and `UDT< FROZEN<MAP> >`. Note: UDT=User Defined Type Jira: DB-7332 Test Plan: ybd --cxx-test ql_ql-select-expr-test --gtest_filter QLTestSelectedExpr.TestQLSelectToJson ybd --java-test org.yb.cql.TestSelect#testToJson Reviewers: mihnea, stiwary Reviewed By: stiwary Subscribers: ybase, yql Differential Revision: https://phorge.dev.yugabyte.com/D27544
OlegLoginov
added a commit
that referenced
this issue
Aug 9, 2023
Summary: Original commit: 8b54187 / D27544 GH link: 8b54187 Before the fix the `TOJSON()` implementation in DocDB did not unpack UDT if it's a field in a parent UDT (a nested UDT). Now it's fixed. The issue affects any `UDT< FROZEN<*> >` combinations - including `UDT< FROZEN<UDT> >`, `UDT< FROZEN<LIST> >`, `UDT< FROZEN<SET> >` and `UDT< FROZEN<MAP> >`. Note: UDT=User Defined Type Jira: DB-7332 Test Plan: ybd --cxx-test ql_ql-select-expr-test --gtest_filter QLTestSelectedExpr.TestQLSelectToJson ybd --java-test org.yb.cql.TestSelect#testToJson Reviewers: mihnea, stiwary, pjain Reviewed By: pjain Subscribers: pjain, yql, ybase Differential Revision: https://phorge.dev.yugabyte.com/D27592
OlegLoginov
added a commit
that referenced
this issue
Aug 9, 2023
Summary: Original commit: 8b54187 / D27544 GH link: 8b54187 Before the fix the `TOJSON()` implementation in DocDB did not unpack UDT if it's a field in a parent UDT (a nested UDT). Now it's fixed. The issue affects any `UDT< FROZEN<*> >` combinations - including `UDT< FROZEN<UDT> >`, `UDT< FROZEN<LIST> >`, `UDT< FROZEN<SET> >` and `UDT< FROZEN<MAP> >`. Note: UDT=User Defined Type Jira: DB-7332 Test Plan: ybd --cxx-test ql_ql-select-expr-test --gtest_filter QLTestSelectedExpr.TestQLSelectToJson ybd --java-test org.yb.cql.TestSelect#testToJson Reviewers: mihnea, stiwary, pjain Reviewed By: pjain Subscribers: pjain, yql, ybase Differential Revision: https://phorge.dev.yugabyte.com/D27593
OlegLoginov
added a commit
that referenced
this issue
Aug 9, 2023
Summary: Original commit: 8b54187 / D27544 GH link: 8b54187 Before the fix the `TOJSON()` implementation in DocDB did not unpack UDT if it's a field in a parent UDT (a nested UDT). Now it's fixed. The issue affects any `UDT< FROZEN<*> >` combinations - including `UDT< FROZEN<UDT> >`, `UDT< FROZEN<LIST> >`, `UDT< FROZEN<SET> >` and `UDT< FROZEN<MAP> >`. Note: UDT=User Defined Type Jira: DB-7332 Test Plan: ybd --cxx-test ql_ql-select-expr-test --gtest_filter QLTestSelectedExpr.TestQLSelectToJson ybd --java-test org.yb.cql.TestSelect#testToJson Reviewers: mihnea, stiwary, pjain Reviewed By: pjain Subscribers: pjain, yql, ybase Differential Revision: https://phorge.dev.yugabyte.com/D27591
OlegLoginov
added a commit
that referenced
this issue
Aug 10, 2023
Summary: Fixing the test which was introduced in the diff: D27544. Commit: 8b54187 Fixed unstable error: ``` Cannot delete type 'cql_test_keyspace.udt'. It is used in field u1 of type 'udt8' ``` Because the test framework can try to delete the `udt` type before the parent type `udt8`. Jira: DB-7332 Test Plan: Jenkins: test regex: .*ToJson.* ybd --java-test org.yb.cql.TestSelect#testToJson ybd --cxx-test ql_ql-select-expr-test --gtest_filter QLTestSelectedExpr.TestQLSelectToJson Reviewers: mihnea, pjain, stiwary Reviewed By: pjain Subscribers: yql Differential Revision: https://phorge.dev.yugabyte.com/D27639
OlegLoginov
added a commit
that referenced
this issue
Aug 11, 2023
…stToJson Summary: Original commit: 2be0a41 / D27639 GH link: 2be0a41 Fixing the test which was introduced in the diff: D27544. Commit: 8b54187 Fixed unstable error: ``` Cannot delete type 'cql_test_keyspace.udt'. It is used in field u1 of type 'udt8' ``` Because the test framework can try to delete the `udt` type before the parent type `udt8`. Jira: DB-7332 Test Plan: Jenkins: test regex: .*ToJson.* ybd --java-test org.yb.cql.TestSelect#testToJson ybd --cxx-test ql_ql-select-expr-test --gtest_filter QLTestSelectedExpr.TestQLSelectToJson Reviewers: mihnea, pjain, stiwary Reviewed By: pjain Subscribers: yql Differential Revision: https://phorge.dev.yugabyte.com/D27712
OlegLoginov
added a commit
that referenced
this issue
Aug 11, 2023
…stToJson Summary: Original commit: 2be0a41 / D27639 GH link: 2be0a41 Fixing the test which was introduced in the diff: D27544. Commit: 8b54187 Fixed unstable error: ``` Cannot delete type 'cql_test_keyspace.udt'. It is used in field u1 of type 'udt8' ``` Because the test framework can try to delete the `udt` type before the parent type `udt8`. Jira: DB-7332 Test Plan: Jenkins: test regex: .*ToJson.* ybd --java-test org.yb.cql.TestSelect#testToJson ybd --cxx-test ql_ql-select-expr-test --gtest_filter QLTestSelectedExpr.TestQLSelectToJson Reviewers: mihnea, pjain, stiwary Reviewed By: pjain Subscribers: yql Differential Revision: https://phorge.dev.yugabyte.com/D27711
OlegLoginov
added a commit
that referenced
this issue
Aug 11, 2023
…stToJson Summary: Original commit: 2be0a41 / D27639 GH link: 2be0a41 Fixing the test which was introduced in the diff: D27544. Commit: 8b54187 Fixed unstable error: ``` Cannot delete type 'cql_test_keyspace.udt'. It is used in field u1 of type 'udt8' ``` Because the test framework can try to delete the `udt` type before the parent type `udt8`. Jira: DB-7332 Test Plan: Jenkins: test regex: .*ToJson.* ybd --java-test org.yb.cql.TestSelect#testToJson ybd --cxx-test ql_ql-select-expr-test --gtest_filter QLTestSelectedExpr.TestQLSelectToJson Reviewers: mihnea, pjain, stiwary Reviewed By: pjain Subscribers: yql Differential Revision: https://phorge.dev.yugabyte.com/D27710
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.14 Backport Required
2.16 Backport Required
2.18 Backport Required
2.18.0_blocker
area/ycql
Yugabyte CQL (YCQL)
kind/bug
This issue is a bug
priority/medium
Medium priority issue
Jira Link: DB-7332
Description
The issue:
YB:
Cassandra:
Warning: Please confirm that this issue does not contain any sensitive information
The text was updated successfully, but these errors were encountered: