Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[yugaware] Enhance call to WaitForLoadBalance to wait for tablets to start moving #1839

Open
bmatican opened this issue Jul 18, 2019 · 0 comments
Open

[yugaware] Enhance call to WaitForLoadBalance to wait for tablets to start moving #1839

bmatican opened this issue Jul 18, 2019 · 0 comments
Assignees
@Arnav15
Labels
area/platform Yugabyte Platform kind/bug This issue is a bug
Projects
User Experience

Comments

@bmatican
Copy link
Contributor

After #1336, we've changed the underlying API that YugaWare uses to figure out if a universe is back to a balanced state.

While this new API guarantees that a client will stop exactly when the load balancer no longer does work, it has a small caveat that, if called before the load balancer even begins doing any work, it might get back an early OK, that the cluster is balanced, because it does not yet know of the incoming work it is supposed to start doing.
@bmatican bmatican added kind/bug This issue is a bug area/ui All issues relating to UI/UX labels Jul 18, 2019
@bmatican bmatican added this to To do in User Experience via automation Jul 18, 2019
Arnav15 added a commit that referenced this issue Jul 22, 2019
@Arnav15
#1839: Add sleep before Wait for Load Balance.
0944ad8 
Summary:
Adding a 10 second timeout before querying the load balancer to check if the load has been
balanced. This can prevent the condition of YW querying the load balancer before it even starts the
task, resulting it to return instantly.

Test Plan: Tested by creating a universe, running a load and then adding a couple of nodes and verifying that the load is balanced on completion of the edit universe.

Reviewers: bogdan

Reviewed By: bogdan

Subscribers: yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D6931
@Arnav15 Arnav15 added area/platform Yugabyte Platform and removed area/ui All issues relating to UI/UX labels Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arnav15 Arnav15

Labels
area/platform Yugabyte Platform kind/bug This issue is a bug
Projects
User Experience
  
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bmatican @Arnav15