Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xCluster] Simplify the xcluster test helper functions #18404

Closed
1 task done
hari90 opened this issue Jul 25, 2023 · 0 comments
Closed
1 task done

[xCluster] Simplify the xcluster test helper functions #18404

hari90 opened this issue Jul 25, 2023 · 0 comments
Assignees
@hari90
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@hari90
Copy link
Contributor

hari90 commented Jul 25, 2023 •
edited by jira bot

Jira Link: DB-7394

Description

SetupUniverseReplication returns a list of tables in a weirdly sorted order. Each xcluster test has to parse and extract out producer and consumer tables from this list. Instead we can directly store the two lists in the base class.

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@hari90 hari90 added kind/enhancement This is an enhancement of an existing feature area/docdb YugabyteDB core features labels Jul 25, 2023
@hari90 hari90 self-assigned this Jul 25, 2023
@yugabyte-ci yugabyte-ci added the priority/medium Medium priority issue label Jul 25, 2023
hari90 added a commit that referenced this issue Jul 27, 2023
@hari90
[#18404] xCluster: Refactor xcluster tests
fd39a9c 
Summary:
SetupUniverseReplication returns a list of tables in a weirdly sorted order. Each xcluster test has to parse and extract out producer and consumer tables from this list. Instead we can directly store the two lists in the base class.
Add useful defaults to helper methods like WriteWorkload to reduce repeated code.
Jira: DB-7394

Test Plan:
xcluster-test
xcluster_ysql-test

Reviewers: slingam, jhe, xCluster

Reviewed By: jhe

Subscribers: ybase

Differential Revision: https://phorge.dev.yugabyte.com/D27136
@hari90 hari90 closed this as completed Jul 27, 2023
hari90 added a commit that referenced this issue Jul 27, 2023
@hari90
[#18404] xCluster: Remove duplicate GetTestParam in xcluster-test
761f13b 
Summary:
Remove duplicate GetTestParam in xcluster-test that was accidentally added in fd39a9c/D27136 due to a bad merge.
Jira: DB-7394

Test Plan: jenkins: urgent, build only

Reviewers: mlillibridge, abharadwaj, xCluster

Reviewed By: abharadwaj

Subscribers: ybase

Differential Revision: https://phorge.dev.yugabyte.com/D27338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hari90 hari90

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hari90 @yugabyte-ci