Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] thirdparty_tool --list-compilers option does not honor other options #18826

Closed
1 task done
svarnau opened this issue Aug 23, 2023 · 2 comments
Closed
1 task done

[Build] thirdparty_tool --list-compilers option does not honor other options #18826

svarnau opened this issue Aug 23, 2023 · 2 comments
Assignees
@svarnau
Labels
area/build-framework Building and packaging third-party dependencies (repo: yugabyte/yugabyte-db-thirdparty) area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage

Comments

@svarnau
Copy link
Member

svarnau commented Aug 23, 2023 •
edited by jira bot

Jira Link: DB-7705

Description

The list-compilers option is used to pre-populate dependency archives on build machines, but it does not honor all the selection options needed:
--is-linuxbrew
--lto
--allow-older-os

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@svarnau svarnau added area/ysql Yugabyte SQL (YSQL) area/build-framework Building and packaging third-party dependencies (repo: yugabyte/yugabyte-db-thirdparty) status/awaiting-triage Issue awaiting triage labels Aug 23, 2023
@svarnau svarnau self-assigned this Aug 23, 2023
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Aug 23, 2023
@svarnau
Copy link
Member Author

svarnau commented Aug 23, 2023

Test cases:
./build-support/thirdparty_tool --list-compilers --os almalinux8 --arch x86_64 --allow-older-os
./build-support/thirdparty_tool --list-compilers --os almalinux8 --arch aarch64 --allow-older-os
./build-support/thirdparty_tool --list-compilers --os almalinux8 --arch x86_64 --is-linuxbrew true
./build-support/thirdparty_tool --list-compilers --os almalinux8 --arch x86_64 --is-linuxbrew true --lto full
./build-support/thirdparty_tool --list-compilers --os almalinux8 --arch x86_64 --is-linuxbrew false --lto full
./build-support/thirdparty_tool --list-compilers --os almalinux8 --arch x86_64 --is-linuxbrew false --lto full --allow-older-os
./build-support/thirdparty_tool --list-compilers --os almalinux8 --arch aarch64 --is-linuxbrew false --allow-older-os --lto full

svarnau added a commit that referenced this issue Aug 24, 2023
@svarnau
[#18826] Build: thirdparty_tool --list-compilers option enhancement
c781baf 
Summary:
The --list-compilers option needs to honor other selection options.

Also send any python/pip stdout to stderr to avoid contaminating
results.
Jira: DB-7705

Test Plan:
Jenkins: skip
Manual test cases as listed in GHI.

Reviewers: mbautin, jharveysmith, odeshmukh

Reviewed By: odeshmukh

Subscribers: devops

Differential Revision: https://phorge.dev.yugabyte.com/D28039
@svarnau
Copy link
Member Author

svarnau commented Aug 24, 2023

Landed on master. Still needs backport to 2.18,2.16,2.14

svarnau added a commit that referenced this issue Aug 30, 2023
@svarnau
[BACKPORT 2.14][#18826] Build: thirdparty_tool --list-compilers optio…
2cb374a 
…n enhancement

Summary:
The --list-compilers option needs to honor other selection options.

Also send any python/pip stdout to stderr to avoid contaminating
results.
Jira: DB-7705
Original commit: c781baf / D28039

allow-older-os option is not supported on 2.14

Test Plan:
Jenkins: skip
Manual test cases as listed in GHI.

Reviewers: mbautin, jharveysmith, odeshmukh

Reviewed By: jharveysmith

Subscribers: devops

Differential Revision: https://phorge.dev.yugabyte.com/D28131
svarnau added a commit that referenced this issue Aug 30, 2023
@svarnau
[BACKPORT 2.16][#18826] Build: thirdparty_tool --list-compilers optio…
5e644b6 
…n enhancement

Summary:
Original commit: c781baf / D28039
The --list-compilers option needs to honor other selection options.

Also send any python/pip stdout to stderr to avoid contaminating
results.
Jira: DB-7705

allow-older-os option is not supported on 2.16

Test Plan:
Jenkins: skip
Manual test cases as listed in GHI.

Reviewers: mbautin, jharveysmith, odeshmukh

Reviewed By: jharveysmith

Subscribers: devops

Differential Revision: https://phorge.dev.yugabyte.com/D28130
svarnau added a commit that referenced this issue Aug 30, 2023
@svarnau
[BACKPORT 2.18][#18826] Build: thirdparty_tool --list-compilers optio…
47bb6de 
…n enhancement

Summary:
Original commit: c781baf / D28039
The --list-compilers option needs to honor other selection options.

Also send any python/pip stdout to stderr to avoid contaminating
results.
Jira: DB-7705

Test Plan:
Jenkins: skip
Manual test cases as listed in GHI.

Reviewers: mbautin, jharveysmith, odeshmukh

Reviewed By: jharveysmith

Subscribers: devops

Differential Revision: https://phorge.dev.yugabyte.com/D28129
@svarnau svarnau closed this as completed Aug 30, 2023
vaibhav-yb pushed a commit to vaibhav-yb/yugabyte-db that referenced this issue Sep 7, 2023
@svarnau @vaibhav-yb
[yugabyte#18826] Build: thirdparty_tool --list-compilers option enhan…
eb3b9c7 
…cement

Summary:
The --list-compilers option needs to honor other selection options.

Also send any python/pip stdout to stderr to avoid contaminating
results.
Jira: DB-7705

Test Plan:
Jenkins: skip
Manual test cases as listed in GHI.

Reviewers: mbautin, jharveysmith, odeshmukh

Reviewed By: odeshmukh

Subscribers: devops

Differential Revision: https://phorge.dev.yugabyte.com/D28039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svarnau svarnau

Labels
area/build-framework Building and packaging third-party dependencies (repo: yugabyte/yugabyte-db-thirdparty) area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@svarnau @yugabyte-ci