Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocDB] Enable Odyssey by default in yb_release #18875

Closed
1 task done
mbautin opened this issue Aug 28, 2023 · 0 comments
Closed
1 task done

[DocDB] Enable Odyssey by default in yb_release #18875

mbautin opened this issue Aug 28, 2023 · 0 comments
Assignees
@mbautin
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@mbautin
Copy link
Collaborator

mbautin commented Aug 28, 2023 •
edited by jira bot

Jira Link: DB-7735

Description

Enable Odyssey connection pooler by default in yb_release

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@mbautin mbautin added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Aug 28, 2023
@mbautin mbautin self-assigned this Aug 28, 2023
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Aug 28, 2023
mbautin added a commit that referenced this issue Aug 28, 2023
@mbautin
[#18875] Enable Odyssey by default in yb_release for core database Li…
f600580 
…nux releases

Summary: Enable Odyssey by default in yb_release for core database Linux releases

Test Plan:
Jenkins: compile only

Manual testing:

```
./yb_release --no_reinitdb  --force --skip_yugabyted_ui
```

Look for the following line in the output:

```
2023-08-28 20:10:49,325 [yb_release_core_db.py:358 INFO] Optional components: OptionalComponents(yugabyted_ui=False, odyssey=True)
```

Verify that the resulting tarball contains the odyssey executable:

```
build/yugabyte-2.19.3.0-b959a3b89847261c1972b56d7871b3a7461a3bed-release-clang15-centos-x86_64.tar.gz | grep odyssey
```

Verify that the argument descriptions for optional components are correct in yb_release.

On Linux:

```
./yb_release --help

. . .

  --with_yugabyted_ui   Enable building yugabyted UI (enabled by default)
  --no_yugabyted_ui, --skip_yugabyted_ui, --skip_yugabyted_ui_build
                        Disable building yugabyted UI (enabled by default)
  --with_odyssey        Enable building Odyssey PostgreSQL connection pooler (enabled by default on Linux)
  --no_odyssey, --skip_odyssey
                        Disable building Odyssey PostgreSQL connection pooler (enabled by default on Linux)
```

On macOS:

```
./yb_release --help

. . .

  --with_yugabyted_ui   Enable building yugabyted UI (enabled by default)
  --no_yugabyted_ui, --skip_yugabyted_ui, --skip_yugabyted_ui_build
                        Disable building yugabyted UI (enabled by default)
  --with_odyssey        Enable building Odyssey PostgreSQL connection pooler (disabled by default)
  --no_odyssey, --skip_odyssey
                        Disable building Odyssey PostgreSQL connection pooler (disabled by default)
```

---

bin/run_codecheck

Reviewers: rbarigidad, jharveysmith

Reviewed By: rbarigidad, jharveysmith

Subscribers: ybase

Differential Revision: https://phorge.dev.yugabyte.com/D28123
jayant07-yb pushed a commit that referenced this issue Aug 29, 2023
[BACKPORT 2.19.2][#18875] ysql: Enable Odyssey by default in yb_relea…
80466c9 
…se for core database Linux releases

Summary:
Enable Odyssey by default in yb_release for core database Linux releases
Original commit: f600580 / D28123
Jira: DB-7735

Test Plan:
Jenkins: compile only

Manual testing:

```
./yb_release --no_reinitdb  --force --skip_yugabyted_ui
```

Look for the following line in the output:

```
2023-08-28 20:10:49,325 [yb_release_core_db.py:358 INFO] Optional components: OptionalComponents(yugabyted_ui=False, odyssey=True)
```

Verify that the resulting tarball contains the odyssey executable:

```
build/yugabyte-2.19.3.0-b959a3b89847261c1972b56d7871b3a7461a3bed-release-clang15-centos-x86_64.tar.gz | grep odyssey
```

Verify that the argument descriptions for optional components are correct in yb_release.

On Linux:

```
./yb_release --help

. . .

  --with_yugabyted_ui   Enable building yugabyted UI (enabled by default)
  --no_yugabyted_ui, --skip_yugabyted_ui, --skip_yugabyted_ui_build
                        Disable building yugabyted UI (enabled by default)
  --with_odyssey        Enable building Odyssey PostgreSQL connection pooler (enabled by default on Linux)
  --no_odyssey, --skip_odyssey
                        Disable building Odyssey PostgreSQL connection pooler (enabled by default on Linux)
```

On macOS:

```
./yb_release --help

. . .

  --with_yugabyted_ui   Enable building yugabyted UI (enabled by default)
  --no_yugabyted_ui, --skip_yugabyted_ui, --skip_yugabyted_ui_build
                        Disable building yugabyted UI (enabled by default)
  --with_odyssey        Enable building Odyssey PostgreSQL connection pooler (disabled by default)
  --no_odyssey, --skip_odyssey
                        Disable building Odyssey PostgreSQL connection pooler (disabled by default)
```

---

bin/run_codecheck

Reviewers: rbarigidad, jharveysmith, nkumar, skumar

Reviewed By: nkumar

Subscribers: ybase

Differential Revision: https://phorge.dev.yugabyte.com/D28147
@mbautin mbautin closed this as completed Aug 30, 2023
vaibhav-yb pushed a commit to vaibhav-yb/yugabyte-db that referenced this issue Sep 7, 2023
@mbautin @vaibhav-yb
[yugabyte#18875] Enable Odyssey by default in yb_release for core dat…
3c967d8 
…abase Linux releases

Summary: Enable Odyssey by default in yb_release for core database Linux releases

Test Plan:
Jenkins: compile only

Manual testing:

```
./yb_release --no_reinitdb  --force --skip_yugabyted_ui
```

Look for the following line in the output:

```
2023-08-28 20:10:49,325 [yb_release_core_db.py:358 INFO] Optional components: OptionalComponents(yugabyted_ui=False, odyssey=True)
```

Verify that the resulting tarball contains the odyssey executable:

```
build/yugabyte-2.19.3.0-b959a3b89847261c1972b56d7871b3a7461a3bed-release-clang15-centos-x86_64.tar.gz | grep odyssey
```

Verify that the argument descriptions for optional components are correct in yb_release.

On Linux:

```
./yb_release --help

. . .

  --with_yugabyted_ui   Enable building yugabyted UI (enabled by default)
  --no_yugabyted_ui, --skip_yugabyted_ui, --skip_yugabyted_ui_build
                        Disable building yugabyted UI (enabled by default)
  --with_odyssey        Enable building Odyssey PostgreSQL connection pooler (enabled by default on Linux)
  --no_odyssey, --skip_odyssey
                        Disable building Odyssey PostgreSQL connection pooler (enabled by default on Linux)
```

On macOS:

```
./yb_release --help

. . .

  --with_yugabyted_ui   Enable building yugabyted UI (enabled by default)
  --no_yugabyted_ui, --skip_yugabyted_ui, --skip_yugabyted_ui_build
                        Disable building yugabyted UI (enabled by default)
  --with_odyssey        Enable building Odyssey PostgreSQL connection pooler (disabled by default)
  --no_odyssey, --skip_odyssey
                        Disable building Odyssey PostgreSQL connection pooler (disabled by default)
```

---

bin/run_codecheck

Reviewers: rbarigidad, jharveysmith

Reviewed By: rbarigidad, jharveysmith

Subscribers: ybase

Differential Revision: https://phorge.dev.yugabyte.com/D28123
@rthallamko3 rthallamko3 removed the status/awaiting-triage Issue awaiting triage label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbautin mbautin

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mbautin @rthallamko3 @yugabyte-ci