[xCluster] Code cleanup on master part 1 #19353
Assignees
Labels
area/docdb
YugabyteDB core features
kind/enhancement
This is an enhancement of an existing feature
priority/medium
Medium priority issue
Comments
hari90
added
area/docdb
yugabyte-ci
added
kind/enhancement
hari90
added a commit
that referenced
this issue
Oct 4, 2023
Summary: Make `allow_ycql_transactional_xcluster` a TEST flag as this feature is not available to end users and only in use for testing of xCluster. Rename cdc to xcluster. Use common helper functions for maps and collections. Move ValidateTableSchema to xrepl_catalog_manager and rename to ValidateTableSchemaForXCluster. Jira: DB-8155 Test Plan: All xcluster tests Reviewers: jhe, xCluster Reviewed By: jhe Subscribers: ybase, ycdcxcluster, bogdan Differential Revision: https://phorge.dev.yugabyte.com/D28943
hari90
added a commit
that referenced
this issue
Oct 12, 2023
Summary: XClusterManager will handle all XCluster related control logic in the yb-master. Moving a few functions and objects from CatalogManager to begin with. Currently XClusterManager is a child of CatalogManager and a friend class since a lot of code is still scattered between the two classes. Over the next few diffs this will be cleaned up. Creating a dedicated class XClusterConfig that handles changes to XClusterConfigInfo changes. Jira: DB-8155 Test Plan: All xCluster tests Reviewers: asrivastava, jhe, xCluster Reviewed By: asrivastava Subscribers: bogdan, ybase, esheng Differential Revision: https://phorge.dev.yugabyte.com/D29042
hari90
added a commit
that referenced
this issue
Oct 13, 2023
…Consumer Summary: Original commit: f53a10b / D28943 Make `allow_ycql_transactional_xcluster` a TEST flag as this feature is not available to end users and only in use for testing of xCluster. Rename cdc to xcluster. Use common helper functions for maps and collections. Move ValidateTableSchema to xrepl_catalog_manager and rename to ValidateTableSchemaForXCluster. Jira: DB-8155 Test Plan: All xcluster tests Reviewers: jhe, xCluster Reviewed By: jhe Subscribers: bogdan, ycdcxcluster, ybase Differential Revision: https://phorge.dev.yugabyte.com/D29097
hari90
added a commit
that referenced
this issue
Oct 13, 2023
Summary: 11 tests related to Collocated dbs have been moved to a separate file. TableGroup related tests have been removed. Jira: DB-8155 Test Plan: xcluster_ysq_colocated-test xcluster_ysq-test Reviewers: jhe, xCluster, slingam Reviewed By: slingam Subscribers: ybase Differential Revision: https://phorge.dev.yugabyte.com/D29257
hari90
added a commit
that referenced
this issue
Oct 13, 2023
Summary: Original commit: e7fb2de / D29042 XClusterManager will handle all XCluster related control logic in the yb-master. Moving a few functions and objects from CatalogManager to begin with. Currently XClusterManager is a child of CatalogManager and a friend class since a lot of code is still scattered between the two classes. Over the next few diffs this will be cleaned up. Creating a dedicated class XClusterConfig that handles changes to XClusterConfigInfo changes. Jira: DB-8155 Test Plan: All xCluster tests Reviewers: asrivastava, jhe, xCluster Reviewed By: asrivastava Subscribers: esheng, ybase, bogdan Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D29312
hari90
changed the title
13 tasks
hari90
added a commit
that referenced
this issue
Nov 15, 2023
…eparate file Summary: Original commit: 46150c0 / D29257 11 tests related to Collocated dbs have been moved to a separate file. TableGroup related tests have been removed. Jira: DB-8155 Test Plan: xcluster_ysq_colocated-test xcluster_ysq-test Reviewers: jhe, xCluster, slingam Reviewed By: slingam Subscribers: ybase Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D30197
jharveysmith
pushed a commit
that referenced
this issue
May 24, 2024
…Consumer Summary: Original commit: 5388ba51ef85e64d0508388da569ecec6a50c255 / D28943 Make `allow_ycql_transactional_xcluster` a TEST flag as this feature is not available to end users and only in use for testing of xCluster. Rename cdc to xcluster. Use common helper functions for maps and collections. Move ValidateTableSchema to xrepl_catalog_manager and rename to ValidateTableSchemaForXCluster. Jira: DB-8155 Test Plan: All xcluster tests Reviewers: jhe, xCluster Reviewed By: jhe Subscribers: bogdan, ycdcxcluster, ybase Differential Revision: https://phorge.dev.yugabyte.com/D29097
jharveysmith
pushed a commit
that referenced
this issue
May 24, 2024
Summary: Original commit: e533472bfaaf1ff66e111d8a69c3efaf1d46e126 / D29042 XClusterManager will handle all XCluster related control logic in the yb-master. Moving a few functions and objects from CatalogManager to begin with. Currently XClusterManager is a child of CatalogManager and a friend class since a lot of code is still scattered between the two classes. Over the next few diffs this will be cleaned up. Creating a dedicated class XClusterConfig that handles changes to XClusterConfigInfo changes. Jira: DB-8155 Test Plan: All xCluster tests Reviewers: asrivastava, jhe, xCluster Reviewed By: asrivastava Subscribers: esheng, ybase, bogdan Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D29312
jharveysmith
pushed a commit
that referenced
this issue
May 24, 2024
…eparate file Summary: Original commit: 91332df0d90c71664811a6e9d8bdbf7216019868 / D29257 11 tests related to Collocated dbs have been moved to a separate file. TableGroup related tests have been removed. Jira: DB-8155 Test Plan: xcluster_ysq_colocated-test xcluster_ysq-test Reviewers: jhe, xCluster, slingam Reviewed By: slingam Subscribers: ybase Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D30197
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira Link: DB-8155
Description
Cleanup some xCluster code.
Warning: Please confirm that this issue does not contain any sensitive information
The text was updated successfully, but these errors were encountered: