Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocDB] Use join_existing_universe flag to prevent initdb or RestoreInitialSysCatalogSnapshot from running #19357

Closed
yugabyte-ci opened this issue Sep 29, 2023 · 0 comments
Closed

[DocDB] Use join_existing_universe flag to prevent initdb or RestoreInitialSysCatalogSnapshot from running #19357

yugabyte-ci opened this issue Sep 29, 2023 · 0 comments
Assignees
@druzac
Labels
area/docdb YugabyteDB core features jira-originated kind/enhancement This is an enhancement of an existing feature priority/high High Priority

Comments

@yugabyte-ci
Copy link
Contributor

yugabyte-ci commented Sep 29, 2023 •
edited by jira bot

Jira Link: DB-8158
@yugabyte-ci yugabyte-ci added area/docdb YugabyteDB core features jira-originated kind/enhancement This is an enhancement of an existing feature priority/low Low priority labels Sep 29, 2023
@yugabyte-ci yugabyte-ci changed the title [DocDB] Use join_existing_universe flag to prevent initdb or restore_snapshot from running [DocDB] Use join_existing_universe flag to prevent initdb or RestoreInitialSysCatalogSnapshot from running Sep 29, 2023
@yugabyte-ci yugabyte-ci added priority/high High Priority and removed priority/low Low priority labels Oct 26, 2023
aishwarya24 pushed a commit to aishwarya24/yugabyte-db that referenced this issue Nov 21, 2023
@druzac
[yugabyte#19357] docdb: Check value of master_join_existing_universe …
7490607 
…flag before restoring sys catalog snapshot.

Summary:
Add a sanity check right before restoring the initial sys catalog snapshot. If the `master_join_existing_universe` flag is set, we assume something has gone wrong as this master should not need to restore the initial sys catalog snapshot.

Jira: DB-8158

Test Plan:
```
ybd --cxx-test catalog_manager_mini_cluster_test
```

Reviewers: asrivastava

Reviewed By: asrivastava

Subscribers: ybase, slingam, bogdan

Differential Revision: https://phorge.dev.yugabyte.com/D29949
@druzac druzac closed this as completed Nov 22, 2023
Spikatrix pushed a commit to Spikatrix/yugabyte-db that referenced this issue Nov 29, 2023
@druzac
[BACKPORT 2.18][yugabyte#19357] docdb: Check value of master_join_exi…
3ea5ca9 
…sting_universe flag before restoring sys catalog snapshot.

Summary:
Original commit: 7490607 / D29949
Add a sanity check right before restoring the initial sys catalog snapshot. If the `master_join_existing_universe` flag is set, we assume something has gone wrong as this master should not need to restore the initial sys catalog snapshot.

Jira: DB-8158

Test Plan:
```
ybd --cxx-test catalog_manager_mini_cluster_test
```

Reviewers: asrivastava

Reviewed By: asrivastava

Subscribers: bogdan, slingam, ybase

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D30402
Spikatrix pushed a commit to Spikatrix/yugabyte-db that referenced this issue Nov 29, 2023
@druzac
[BACKPORT 2.20][yugabyte#19357] docdb: Check value of master_join_exi…
9945eb4 
…sting_universe flag before restoring sys catalog snapshot.

Summary:
Original commit: 7490607 / D29949
Add a sanity check right before restoring the initial sys catalog snapshot. If the `master_join_existing_universe` flag is set, we assume something has gone wrong as this master should not need to restore the initial sys catalog snapshot.

Jira: DB-8158

Test Plan:
```
ybd --cxx-test catalog_manager_mini_cluster_test
```

Reviewers: asrivastava

Reviewed By: asrivastava

Subscribers: bogdan, slingam, ybase

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D30400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@druzac druzac

Labels
area/docdb YugabyteDB core features jira-originated kind/enhancement This is an enhancement of an existing feature priority/high High Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@druzac @yugabyte-ci