Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change output format of prometheus metrics #19484

Closed
yugabyte-ci opened this issue Oct 11, 2023 · 0 comments
Closed

Change output format of prometheus metrics #19484

yugabyte-ci opened this issue Oct 11, 2023 · 0 comments
Assignees
@rahulb-yb
Labels
area/ecosystem Label for all ecosystem related projects jira-originated kind/new-feature This is a request for a completely new feature priority/highest Highest priority issue

Comments

@yugabyte-ci
Copy link
Contributor

yugabyte-ci commented Oct 11, 2023 •
edited by jira bot

Jira Link: DB-8283
@yugabyte-ci yugabyte-ci added area/ecosystem Label for all ecosystem related projects jira-originated kind/new-feature This is a request for a completely new feature priority/highest Highest priority issue labels Oct 11, 2023
rahulb-yb pushed a commit that referenced this issue Oct 19, 2023
[#19484] YSQL:Include database as a metric label for YSQL Connection …
ce82d2c 
…Manager Prometheus Metrics

Summary:
This diff changes the format of YSQL connection manager prometheus metrics being published on the prometheus-metrics endpoint (`tserver_ip:13000/prometheus-metrics`)

Older format of prometheus metrics:
`ysql_conn_mgr_<db_name>_<metrics>{attr1 = value1, attr2 = value2...}`

Change being made to format in this diff:
`ysql_conn_mgr_<metrics>{attr1 = value1, attr2 = value2..., <db_name> = value3}`

Jira: DB-8283

Test Plan:
Manually verified via curl request on the prometheus-metrics endpoint:

```
curl 10.9.8.146:13000/prometheus-metrics

yb_ysqlserver_active_connection_total{metric_id="yb.ysqlserver",metric_type="server",exported_instance="ip-10-9-8-146.us-west-2.compute.internal:9000"} 0 1697175972417
yb_ysqlserver_connection_total{metric_id="yb.ysqlserver",metric_type="server",exported_instance="ip-10-9-8-146.us-west-2.compute.internal:9000"} 2 1697175972417
yb_ysqlserver_max_connection_total{metric_id="yb.ysqlserver",metric_type="server",exported_instance="ip-10-9-8-146.us-west-2.compute.internal:9000"} 300 1697175972417
yb_ysqlserver_connection_over_limit_total{metric_id="yb.ysqlserver",metric_type="server",exported_instance="ip-10-9-8-146.us-west-2.compute.internal:9000"} 0 1697175972417
yb_ysqlserver_new_connection_total{metric_id="yb.ysqlserver",metric_type="server",exported_instance="ip-10-9-8-146.us-west-2.compute.internal:9000"} 2 1697175972417
ysql_conn_mgr_active_clients{exported_instance="ip-10-9-8-146.us-west-2.compute.internal:9000",metric_type="server",database="yugabyte",metric_id="yb.ysqlserver"} 0 1697175972417
ysql_conn_mgr_queued_clients{exported_instance="ip-10-9-8-146.us-west-2.compute.internal:9000",metric_type="server",database="yugabyte",metric_id="yb.ysqlserver"} 0 1697175972417
ysql_conn_mgr_idle_or_pending_clients{exported_instance="ip-10-9-8-146.us-west-2.compute.internal:9000",metric_type="server",database="yugabyte",metric_id="yb.ysqlserver"} 1 1697175972417
ysql_conn_mgr_active_servers{exported_instance="ip-10-9-8-146.us-west-2.compute.internal:9000",metric_type="server",database="yugabyte",metric_id="yb.ysqlserver"} 0 1697175972417
ysql_conn_mgr_idle_servers{exported_instance="ip-10-9-8-146.us-west-2.compute.internal:9000",metric_type="server",database="yugabyte",metric_id="yb.ysqlserver"} 0 1697175972417
ysql_conn_mgr_query_rate{exported_instance="ip-10-9-8-146.us-west-2.compute.internal:9000",metric_type="server",database="yugabyte",metric_id="yb.ysqlserver"} 0 1697175972417
ysql_conn_mgr_transaction_rate{exported_instance="ip-10-9-8-146.us-west-2.compute.internal:9000",metric_type="server",database="yugabyte",metric_id="yb.ysqlserver"} 0 1697175972417
ysql_conn_mgr_avg_wait_time_ns{exported_instance="ip-10-9-8-146.us-west-2.compute.internal:9000",metric_type="server",database="yugabyte",metric_id="yb.ysqlserver"} 0 1697175972417
```

Reviewers: janand, abalakrishnan, akaushik

Reviewed By: janand, abalakrishnan, akaushik

Subscribers: akaushik, yql

Differential Revision: https://phorge.dev.yugabyte.com/D29308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahulb-yb rahulb-yb

Labels
area/ecosystem Label for all ecosystem related projects jira-originated kind/new-feature This is a request for a completely new feature priority/highest Highest priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yugabyte-ci @rahulb-yb