Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CDCSDK] YBClient retries are not seen in case of CDCErrorException #19648

Closed
yugabyte-ci opened this issue Oct 25, 2023 · 0 comments
Closed

[CDCSDK] YBClient retries are not seen in case of CDCErrorException #19648

yugabyte-ci opened this issue Oct 25, 2023 · 0 comments
Assignees
@Sumukh-Phalgaonkar
Labels
area/cdcsdk CDC SDK jira-originated kind/new-feature This is a request for a completely new feature priority/low Low priority

Comments

@yugabyte-ci
Copy link
Contributor

yugabyte-ci commented Oct 25, 2023 •
edited by jira bot

Jira Link: DB-8430
@yugabyte-ci yugabyte-ci added area/cdcsdk CDC SDK jira-originated kind/new-feature This is a request for a completely new feature priority/low Low priority status/awaiting-triage Issue awaiting triage labels Oct 25, 2023
@yugabyte-ci yugabyte-ci removed the status/awaiting-triage Issue awaiting triage label Oct 25, 2023
Sumukh-Phalgaonkar added a commit that referenced this issue Nov 2, 2023
@Sumukh-Phalgaonkar
[#19648]CDCSDK:Fix yb-client retries in case of CdcErrorException
35f7dae 
Summary:
Currently whenever a CDCErrorException is encountered in yb-client, the method dispatchCDCErrorOrReturnException  checks if its a retryable error and eventually returns the exception (regardless of whether the exception was handled or not). This returning of exception leads to calling of the errback which results in resetting of number of attempts, deadline etc. and eventually the exception is thrown to the connector.
This diff, makes the requirred changes so that yb-client retries take place for retryable error
codes.
Jira: DB-8430

Test Plan: Manual Testing

Reviewers: skumar, vkushwaha

Reviewed By: skumar

Subscribers: yugaware, ycdcxcluster

Differential Revision: https://phorge.dev.yugabyte.com/D29688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sumukh-Phalgaonkar Sumukh-Phalgaonkar

Labels
area/cdcsdk CDC SDK jira-originated kind/new-feature This is a request for a completely new feature priority/low Low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yugabyte-ci @Sumukh-Phalgaonkar