Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifying PK on a table disables FORCE RLS. #19815

Closed
yugabyte-ci opened this issue Nov 2, 2023 · 1 comment
Closed

Modifying PK on a table disables FORCE RLS. #19815

yugabyte-ci opened this issue Nov 2, 2023 · 1 comment
Assignees
@fizaaluthra
Labels
area/ysql Yugabyte SQL (YSQL) jira-originated kind/new-feature This is a request for a completely new feature priority/high High Priority

Comments

@yugabyte-ci
Copy link
Contributor

yugabyte-ci commented Nov 2, 2023 •
edited by jira bot

Jira Link: DB-8750
@yugabyte-ci yugabyte-ci added jira-originated kind/new-feature This is a request for a completely new feature priority/high High Priority status/awaiting-triage Issue awaiting triage area/ysql Yugabyte SQL (YSQL) labels Nov 2, 2023
@yugabyte-ci yugabyte-ci removed the status/awaiting-triage Issue awaiting triage label Nov 14, 2023
@fizaaluthra fizaaluthra changed the title Modifying PK on a table disables RLS. Modifying PK on a table disables FORCE RLS. Nov 14, 2023
@fizaaluthra
Copy link
Contributor

note:
For 2.18 and above, this only applies to FORCE RLS. ENABLE RLS (and policies) preserved in 2.18+.

fizaaluthra added a commit that referenced this issue Nov 15, 2023
@fizaaluthra
[#19815] YSQL: Fix table rewrite disables FORCE RLS setting
8ce7cb8 
Summary:
Currently, when copying metadata from the old table during table rewrite, we copy `relrowsecurity`
but incorrectly omit `relforcerowsecurity`. Both of these fields must be copied to preserve
the RLS behavior table rewrite. This diff fixes the issue.
Jira: DB-8750

Test Plan: ./yb_build.sh --java-test 'org.yb.pgsql.TestPgAlterTableChangePrimaryKey'

Reviewers: myang

Reviewed By: myang

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D30164
Spikatrix pushed a commit to Spikatrix/yugabyte-db that referenced this issue Nov 29, 2023
@fizaaluthra
[BACKPORT 2.18][yugabyte#19815] YSQL: Fix table rewrite disables FORC…
b62367d 
…E RLS setting

Summary:
Currently, when copying metadata from the old table during table rewrite, we copy `relrowsecurity`
but incorrectly omit `relforcerowsecurity`. Both of these fields must be copied to preserve
the RLS behavior table rewrite. This diff fixes the issue.
Jira: DB-8750

Test Plan:
./yb_build.sh --java-test 'org.yb.pgsql.TestPgAlterTableChangePrimaryKey'

Original commit: 8ce7cb8 / D30164

Reviewers: myang

Reviewed By: myang

Subscribers: yql

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D30320
Spikatrix pushed a commit to Spikatrix/yugabyte-db that referenced this issue Nov 29, 2023
@fizaaluthra
[BACKPORT 2.20][yugabyte#19815] YSQL: Fix table rewrite disables FORC…
d035a49 
…E RLS setting

Summary:
Currently, when copying metadata from the old table during table rewrite, we copy `relrowsecurity`
but incorrectly omit `relforcerowsecurity`. Both of these fields must be copied to preserve
the RLS behavior table rewrite. This diff fixes the issue.
Jira: DB-8750

Test Plan:
./yb_build.sh --java-test 'org.yb.pgsql.TestPgAlterTableChangePrimaryKey'

Original commit: 8ce7cb8 / D30164

Reviewers: myang

Reviewed By: myang

Subscribers: yql

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D30321
fizaaluthra added a commit that referenced this issue Dec 4, 2023
@fizaaluthra
[BACKPORT 2.16][#19815] YSQL: Fix table rewrite disables FORCE RLS se…
2c1e9bb 
…tting

Summary:
Currently, when copying metadata from the old table during table rewrite, we copy `relrowsecurity`
but incorrectly omit `relforcerowsecurity`. Both of these fields must be copied to preserve
the RLS behavior table rewrite. This diff fixes the issue.
Jira: DB-8750

Original commit: 8ce7cb8 / D30164

Test Plan: ./yb_build.sh --java-test 'org.yb.pgsql.TestPgAlterTableChangePrimaryKey'

Reviewers: myang

Reviewed By: myang

Subscribers: yql

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D30610
fizaaluthra added a commit that referenced this issue Dec 7, 2023
@fizaaluthra
[BACKPORT 2.14][#19815] YSQL: Fix table rewrite disables FORCE RLS se…
10d59ef 
…tting

Summary:
Currently, when copying metadata from the old table during table rewrite, we copy `relrowsecurity`
but incorrectly omit `relforcerowsecurity`. Both of these fields must be copied to preserve
the RLS behavior table rewrite. This diff fixes the issue.
Jira: DB-8750

Original commit: 8ce7cb8 / D30164

Test Plan: ./yb_build.sh --java-test 'org.yb.pgsql.TestPgAlterTableChangePrimaryKey'

Reviewers: myang

Reviewed By: myang

Subscribers: yql

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D30645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fizaaluthra fizaaluthra

Labels
area/ysql Yugabyte SQL (YSQL) jira-originated kind/new-feature This is a request for a completely new feature priority/high High Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yugabyte-ci @fizaaluthra