Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocDB] Correctly handle situation when postgres crashes in the middle of sending request via shared memory #20050

Closed
1 task done
spolitov opened this issue Nov 28, 2023 · 0 comments
Closed
1 task done

[DocDB] Correctly handle situation when postgres crashes in the middle of sending request via shared memory #20050

spolitov opened this issue Nov 28, 2023 · 0 comments
Assignees
@spolitov
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@spolitov
Copy link
Contributor

spolitov commented Nov 28, 2023 •
edited by jira bot

Jira Link: DB-9013

Description

It could happen that postgres process crash while sending request via shared memory.
In this case we could get into situation where mutex is locked forever.
And TServer thread is blocked, since it is waiting on condition with this mutex.

Should handle such scenario correctly.

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@spolitov spolitov added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Nov 28, 2023
@spolitov spolitov self-assigned this Nov 28, 2023
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Nov 28, 2023
spolitov added a commit that referenced this issue Dec 4, 2023
@spolitov
[#20050] DocDB: Correctly handle situation when postgres crashes in t…
202712d 
…he middle of sending request via shared memory

Summary:
It could happen that postgres process crash while sending request via shared memory.
In this case we could get into situation where mutex is locked forever.
And TServer thread is blocked, since it is waiting on condition with this mutex.

Migrated to semaphores to handle this situation correctly.
Jira: DB-9013

Test Plan: PgSharedMemoryTest.Crash

Reviewers: tnayak

Reviewed By: tnayak

Subscribers: ybase, yql, bogdan

Differential Revision: https://phorge.dev.yugabyte.com/D30533
@yugabyte-ci yugabyte-ci removed the status/awaiting-triage Issue awaiting triage label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spolitov spolitov

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@spolitov @rthallamko3 @yugabyte-ci