Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] Cleanup after killed background processes #20154

Closed
1 task done
timothy-e opened this issue Dec 4, 2023 · 0 comments
Closed
1 task done

[YSQL] Cleanup after killed background processes #20154

timothy-e opened this issue Dec 4, 2023 · 0 comments
Assignees
@timothy-e
Labels
area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug priority/highest Highest priority issue

Comments

@timothy-e
Copy link
Contributor

timothy-e commented Dec 4, 2023 •
edited by jira bot

Jira Link: DB-9090

Description

for i in {1..10}; do pkill -9 -ef "YSQL webserver" && sleep 2; done

Will kill the webserver only 8 times. The 9th+ time the webserver attempts to start, it will fail with

FATAL:  sorry, too many clients already

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@timothy-e timothy-e added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels Dec 4, 2023
@timothy-e timothy-e self-assigned this Dec 4, 2023
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue priority/highest Highest priority issue and removed status/awaiting-triage Issue awaiting triage priority/medium Medium priority issue labels Dec 4, 2023
timothy-e added a commit that referenced this issue Dec 5, 2023
@timothy-e
[#20154] YSQL: Background worker cleanup
90dcf23 
Summary:
In D20454, we enabled cleaning up after killed backends.

Background workers were missed, so killing  background worker uses up a Proc struct that is never returned.
Jira: DB-9090

Test Plan:
```
./yb_build.sh --cxx-test pgwrapper_pg_libpq-test --gtest_filter PgLibPqTest.TestWebserverKill
for i in {1..600}; do pkill -9 -ef "YSQL webserver" && sleep 2; done
```

Reviewers: smishra, amartsinchyk

Reviewed By: amartsinchyk

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D30696
timothy-e added a commit that referenced this issue Dec 7, 2023
@timothy-e
[BACKPORT 2.20.1][#20154] YSQL: Background worker cleanup
bbcaeef 
Summary:
Original commit: 90dcf23 / D30696
In D20454, we enabled cleaning up after killed backends.

Background workers were missed, so killing  background worker uses up a Proc struct that is never returned.
Jira: DB-9090

fix function call

Test Plan:
```
./yb_build.sh --cxx-test pgwrapper_pg_libpq-test --gtest_filter PgLibPqTest.TestWebserverKill
for i in {1..600}; do pkill -9 -ef "YSQL webserver" && sleep 2; done
```

Reviewers: smishra, amartsinchyk

Reviewed By: amartsinchyk

Subscribers: yql

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D30790
timothy-e added a commit that referenced this issue Dec 7, 2023
@timothy-e
[BACKPORT 2.20][#20154] YSQL: Background worker cleanup
2dae99d 
Summary:
Original commit: 90dcf23 / D30696
In D20454, we enabled cleaning up after killed backends.

Background workers were missed, so killing  background worker uses up a Proc struct that is never returned.
Jira: DB-9090

Test Plan:
```
./yb_build.sh --cxx-test pgwrapper_pg_libpq-test --gtest_filter PgLibPqTest.TestWebserverKill
for i in {1..600}; do pkill -9 -ef "YSQL webserver" && sleep 2; done
```

Reviewers: smishra, amartsinchyk

Reviewed By: amartsinchyk

Subscribers: yql

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D30745
timothy-e added a commit that referenced this issue Dec 7, 2023
@timothy-e
[BACKPORT 2.18][#20154] YSQL: Background worker cleanup
49ceb35 
Summary:
Original commit: 90dcf23 / D30696
In D20454, we enabled cleaning up after killed backends.

Background workers were missed, so killing  background worker uses up a Proc struct that is never returned.
Jira: DB-9090

Test Plan:
```
./yb_build.sh --cxx-test pgwrapper_pg_libpq-test --gtest_filter PgLibPqTest.TestWebserverKill
for i in {1..600}; do pkill -9 -ef "YSQL webserver" && sleep 2; done
```

Reviewers: smishra, amartsinchyk

Reviewed By: amartsinchyk

Subscribers: yql

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D30746
timothy-e added a commit that referenced this issue Dec 7, 2023
@timothy-e
[BACKPORT 2.16][#20154] YSQL: Background worker cleanup
6e1bf42 
Summary:
Original commit: 90dcf23 / D30696
In D20454, we enabled cleaning up after killed backends.

Background workers were missed, so killing  background worker uses up a Proc struct that is never returned.
Jira: DB-9090

Test Plan:
```
./yb_build.sh --cxx-test pgwrapper_pg_libpq-test --gtest_filter PgLibPqTest.TestWebserverKill
for i in {1..600}; do pkill -9 -ef "YSQL webserver" && sleep 2; done
```

Reviewers: smishra, amartsinchyk

Reviewed By: amartsinchyk

Subscribers: yql

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D30747
timothy-e added a commit that referenced this issue Dec 7, 2023
@timothy-e
[BACKPORT 2.14][#20154] YSQL: Background worker cleanup
fdf2ae1 
Summary:
Original commit: 90dcf23 / D30696
In D20454, we enabled cleaning up after killed backends.

Background workers were missed, so killing  background worker uses up a Proc struct that is never returned.
Jira: DB-9090

Test Plan:
```
./yb_build.sh --cxx-test pgwrapper_pg_libpq-test --gtest_filter PgLibPqTest.TestWebserverKill
for i in {1..600}; do pkill -9 -ef "YSQL webserver" && sleep 2; done
```

Reviewers: smishra, amartsinchyk

Reviewed By: amartsinchyk

Subscribers: yql

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D30748
timothy-e added a commit that referenced this issue Dec 7, 2023
@timothy-e
[BACKPORT 2.18.5][#20154] YSQL: Background worker cleanup
db9ad16 
Summary:
Original commit: 90dcf23 / D30696
In D20454, we enabled cleaning up after killed backends.

Background workers were missed, so killing  background worker uses up a Proc struct that is never returned.
Jira: DB-9090

Test Plan:
```
./yb_build.sh --cxx-test pgwrapper_pg_libpq-test --gtest_filter PgLibPqTest.TestWebserverKill
for i in {1..600}; do pkill -9 -ef "YSQL webserver" && sleep 2; done
```

Reviewers: smishra, amartsinchyk

Reviewed By: amartsinchyk

Subscribers: yql

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D30836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timothy-e timothy-e

Labels
area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug priority/highest Highest priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yugabyte-ci @timothy-e