Fix persistence of consistent snapshot related details of cdcsdk stream metadata in sys_catalog #20202
Assignees
Labels
Comments
yugabyte-ci
added
area/cdcsdk
|
The cdcsdk stream metadata is updated with the consistent snapshot related details (consistent snapshot time and consistent snapshot option). However, this update is not getting persisted in sys_catalog. |
asrinivasanyb
added a commit
that referenced
this issue
Dec 7, 2023
…ls of cdcsdk stream metadata in sys_catalog Summary: This is related to the CDC Consistent Snapshot feature (GH #18508). The cdcsdk stream metadata is updated with the consistent snapshot related details (consistent snapshot time and consistent snapshot option). However, this update was not getting persisted in the sys_catalog. This diff fixes this bug by calling "sys_catalog_->Upsert" for the stream in question. UPGRADE/ROLLBACK SAFETY: Upgrade safe Rollback safe The CDC Consistent Snapshot feature is currently disabled. Changes are guarded by the TEST flag yb_enable_cdc_consistent_snapshot_streams which is set to false by default. This same flag will be redefined as an autoflag (LocalPersisted) once all the support for this feature is in place. Jira: DB-9156 Test Plan: Jenkins: test regex: .*CDCSDKConsistentSnapshotTest.* New Unit Test - .yb_build.sh --cxx-test integration-tests_cdcsdk_consistent_snapshot-test --gtest_filter CDCSDKConsistentSnapshotTest.TestConsistentSnapshotMetadataPersistence Reviewers: skumar, stiwary, xCluster, hsunder Reviewed By: skumar Subscribers: ycdcxcluster, ybase, bogdan Differential Revision: https://phorge.dev.yugabyte.com/D30787
asrinivasanyb
added a commit
that referenced
this issue
Dec 15, 2023
…t related details of cdcsdk stream metadata in sys_catalog Summary: **Backport Description** The merge was clean **Original Description** Original commit: 0053554 / D30787 This is related to the CDC Consistent Snapshot feature (GH #18508). The cdcsdk stream metadata is updated with the consistent snapshot related details (consistent snapshot time and consistent snapshot option). However, this update was not getting persisted in the sys_catalog. This diff fixes this bug by calling "sys_catalog_->Upsert" for the stream in question. UPGRADE/ROLLBACK SAFETY: Upgrade safe Rollback safe The CDC Consistent Snapshot feature is currently disabled. Changes are guarded by the TEST flag yb_enable_cdc_consistent_snapshot_streams which is set to false by default. This same flag will be redefined as an autoflag (LocalPersisted) once all the support for this feature is in place. Jira: DB-9156 Test Plan: Jenkins: test regex: .*CDCSDKConsistentSnapshotTest.* New Unit Test - ./yb_build.sh --cxx-test integration-tests_cdcsdk_consistent_snapshot-test --gtest_filter CDCSDKConsistentSnapshotTest.TestConsistentSnapshotMetadataPersistence Reviewers: skumar, stiwary, xCluster, hsunder Reviewed By: skumar Subscribers: bogdan, ybase, ycdcxcluster Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D31114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira Link: DB-9156
The text was updated successfully, but these errors were encountered: