Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocDB] Interprocess semaphore throws an exception when interrupted #20325

Closed
1 task done
spolitov opened this issue Dec 15, 2023 · 0 comments
Closed
1 task done

[DocDB] Interprocess semaphore throws an exception when interrupted #20325

spolitov opened this issue Dec 15, 2023 · 0 comments
Assignees
@spolitov
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue

Comments

@spolitov
Copy link
Contributor

spolitov commented Dec 15, 2023 •
edited by jira bot

Jira Link: DB-9311

Description

It could happen that interprocess semaphore is interrupted.
In this case boost::interprocess::interprocess_semaphore throws an exception.
So application could crash because of that.

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@spolitov spolitov added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Dec 15, 2023
@spolitov spolitov self-assigned this Dec 15, 2023
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue and removed status/awaiting-triage Issue awaiting triage labels Dec 15, 2023
spolitov added a commit that referenced this issue Dec 17, 2023
@spolitov
[#20325] DocDB: Handle exception thrown by interprocess semaphore wait
6ff8071 
Summary:
It could happen that interprocess semaphore is interrupted.
In this case boost::interprocess::interprocess_semaphore throws an exception.
So application could crash because of that.

boost::interprocess::interprocess_semaphore just a wrapper over pthread semaphore.
Implement our own semaphore that would not throw an exception in this case.
Jira: DB-9311

Test Plan: PgLibPqTest.SecondaryIndexInsertSelectWithSharedMem

Reviewers: tnayak

Reviewed By: tnayak

Subscribers: ybase, yql, bogdan

Differential Revision: https://phorge.dev.yugabyte.com/D31115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spolitov spolitov

Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@spolitov @rthallamko3 @yugabyte-ci