Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DocDB] Disable wait-on-conflict in 2.21.0 #20978

Closed
1 task done
robertsami opened this issue Feb 7, 2024 · 0 comments
Closed
1 task done

[DocDB] Disable wait-on-conflict in 2.21.0 #20978

robertsami opened this issue Feb 7, 2024 · 0 comments
Assignees
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue

Comments

@robertsami
Copy link
Contributor

robertsami commented Feb 7, 2024

Jira Link: DB-9954

Description

#18394 represents a launch-blocking issue for wait-on-conflict. We should disable this feature in 2.21.0 until that issue is resolved

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@robertsami robertsami added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Feb 7, 2024
@robertsami robertsami self-assigned this Feb 7, 2024
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue and removed status/awaiting-triage Issue awaiting triage labels Feb 7, 2024
robertsami added a commit that referenced this issue Feb 8, 2024
Summary:
We've discovered the root cause of #18394 is a launch-blocking bug for wait-on-conflict. In particular, the wait queue assumes that only one request will be sent per session to a given tablet. When this assumption is broken, we outright reject requests.

This revision disables the feature by default.
Jira: DB-9954

Test Plan: Jenkins: compile-only

Reviewers: rthallam, bkolagani

Reviewed By: rthallam, bkolagani

Subscribers: ybase

Differential Revision: https://phorge.dev.yugabyte.com/D32257
robertsami added a commit that referenced this issue Mar 6, 2024
Summary:
In, 586c43d, we disabled wait-on-conflict by default in 2.21.0 due
to the bug described in #18394. With bd361f4, this bug is addressed and it is safe to re-enable
wait-on-conflict in this branch.

This reverts commit 586c43d
Jira: DB-9954

Test Plan: Jenkins: urgent

Reviewers: bkolagani, mihnea, rthallam

Reviewed By: rthallam

Subscribers: rthallam, ybase

Differential Revision: https://phorge.dev.yugabyte.com/D32871
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue
Projects
Status: Done
Development

No branches or pull requests

3 participants