Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] Feature Support - ALTER AGGREGATE #2172

Open
jaki opened this issue Aug 27, 2019 · 0 comments
Open

[YSQL] Feature Support - ALTER AGGREGATE #2172

jaki opened this issue Aug 27, 2019 · 0 comments
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
YSQL

Comments

@jaki
Copy link
Contributor

jaki commented Aug 27, 2019 •
edited by yugabyte-ci

Jira Link: DB-1683
ALTER AGGREGATE is not yet supported.
@jaki jaki added the area/ysql Yugabyte SQL (YSQL) label Aug 27, 2019
@jaki jaki added this to To do in YSQL via automation Aug 27, 2019
@jaki jaki mentioned this issue Aug 27, 2019
Closed
@ndeodhar ndeodhar moved this from To do to Backlog in YSQL Aug 5, 2020
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Jun 8, 2022
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature and removed kind/bug This issue is a bug labels Sep 5, 2022
jasonyb pushed a commit that referenced this issue Apr 14, 2023
@jaki
[#2172] ysql: support ALTER AGGREGATE RENAME TO
df1c2f1 
Summary:
Simply make a grammar change to enable the ALTER AGGREGATE RENAME TO
statement.  It is a RenameStmt, so it is categorized as a breaking
catalog change, which is the safest level.

Update regress tests' output.

Leave issue #2172 open since ALTER AGGREGATE SET SCHEMA is still not
supported.

Depends on D24379

Test Plan:
    #!/usr/bin/env zsh
    ./yb_build.sh fastdebug --gcc11
    for test (TestPgRegressAggregates
              TestPgRegressContribPgaudit
              TestPgRegressPgMiscIndependent)
      ./yb_build.sh fastdebug --gcc11 --sj --java-test "$test"

Reviewers: fizaa

Reviewed By: fizaa

Subscribers: fizaa, yql

Differential Revision: https://phabricator.dev.yugabyte.com/D24382
premkumr pushed a commit to premkumr/yugabyte-db that referenced this issue Apr 14, 2023
@jaki @premkumr
[yugabyte#2172] ysql: support ALTER AGGREGATE RENAME TO
24a551a 
Summary:
Simply make a grammar change to enable the ALTER AGGREGATE RENAME TO
statement.  It is a RenameStmt, so it is categorized as a breaking
catalog change, which is the safest level.

Update regress tests' output.

Leave issue yugabyte#2172 open since ALTER AGGREGATE SET SCHEMA is still not
supported.

Depends on D24379

Test Plan:
    #!/usr/bin/env zsh
    ./yb_build.sh fastdebug --gcc11
    for test (TestPgRegressAggregates
              TestPgRegressContribPgaudit
              TestPgRegressPgMiscIndependent)
      ./yb_build.sh fastdebug --gcc11 --sj --java-test "$test"

Reviewers: fizaa

Reviewed By: fizaa

Subscribers: fizaa, yql

Differential Revision: https://phabricator.dev.yugabyte.com/D24382
jasonyb pushed a commit that referenced this issue Apr 15, 2023
@jaki
[#2172] test: fix bad merge of commit df1c2f1
71c4042 
Summary:
Somehow, merge was bad when working on D24382, commit
df1c2f1, titled

    [#2172] ysql: support ALTER AGGREGATE RENAME TO

It omitted the changes to yb_pg_pgaudit.sql.  This causes test
TestPgRegressContribPgaudit to fail.  The test plan was locally run
after the manual merge resolution, but it was missed that the Pgaudit
test failed because the test script had no `set -e` to catch bad exit
codes in the middle: it ended up continuing and outputting good exit
code in the end.

Bring back the missing change.

Test Plan:
    ./yb_build.sh fastdebug --gcc11 \
      --java-test TestPgRegressContribPgaudit

Reviewers: fizaa

Reviewed By: fizaa

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D24486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
YQL-beta
Status: No status
YSQL
  
Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ndeodhar @jaki @yugabyte-ci