-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YSQL][randgen] Index Scan with inequality row comparison access key returns wrong results #21847
Closed
1 task done
Labels
Comments
tanujnay112
added a commit
that referenced
this issue
Apr 15, 2024
…w NULL's Summary: RowCompareExpressions on a set of columns implicitly need to enforce that its referred columns are non-null. The pushed down RowCompareExpressions don't enforce this properly. This diff fixes that behavior. Jira: DB-10747 Test Plan: ./yb_build.sh --java-test 'org.yb.pg.TestPgRegressIndex' Reviewers: amartsinchyk, telgersma Reviewed By: telgersma Subscribers: yql Differential Revision: https://phorge.dev.yugabyte.com/D34007
tanujnay112
added a commit
that referenced
this issue
Apr 17, 2024
…ssions don't allow NULL's Summary: Original commit: 5595277 / D34007 RowCompareExpressions on a set of columns implicitly need to enforce that its referred columns are non-null. The pushed down RowCompareExpressions don't enforce this properly. This diff fixes that behavior. Jira: DB-10747 Test Plan: ./yb_build.sh --java-test 'org.yb.pg.TestPgRegressIndex' Reviewers: amartsinchyk, telgersma Reviewed By: telgersma Subscribers: yql Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D34133
tanujnay112
added a commit
that referenced
this issue
Apr 17, 2024
…ions don't allow NULL's Summary: Original commit: 5595277 / D34007 RowCompareExpressions on a set of columns implicitly need to enforce that its referred columns are non-null. The pushed down RowCompareExpressions don't enforce this properly. This diff fixes that behavior. Jira: DB-10747 Test Plan: ./yb_build.sh --java-test 'org.yb.pg.TestPgRegressIndex' Reviewers: amartsinchyk, telgersma Reviewed By: telgersma Subscribers: yql Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D34134
tanujnay112
added a commit
that referenced
this issue
Apr 18, 2024
…ions don't allow NULL's Summary: Original commit: 5595277 / D34007 RowCompareExpressions on a set of columns implicitly need to enforce that its referred columns are non-null. The pushed down RowCompareExpressions don't enforce this properly. This diff fixes that behavior. Backport note: On more recent branches, pushing down IS NOT NULL is supported. However, that is not the case on 2.18. For that reason, on this backport we edited the change to just recheck RC filters if they are not on a primary index. Jira: DB-10747 Test Plan: ./yb_build.sh --java-test 'org.yb.pg.TestPgRegressIndex' Reviewers: amartsinchyk, telgersma Reviewed By: telgersma Subscribers: yql Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D34135
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Jira Link: DB-10747
Description
Problem
Index Cond: (ROW(col_bigint_key, col_varchar_10_key) >= ROW(8, ' '::text))
returns 110 rows (Both old and new CBO produces the same plan for this query):Index Cond: (col_bigint_key >= 8)
+Filter: (ROW(col_bigint_key, (col_varchar_10_key)::text) >= ROW(8, ' '::text))
both return 88 rows.Test Case
Issue Type
kind/bug
Warning: Please confirm that this issue does not contain any sensitive information
The text was updated successfully, but these errors were encountered: