Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DocDB] Fatal: Check failed: call #21917

Closed
1 task done
shishir2001-yb opened this issue Apr 11, 2024 · 0 comments
Closed
1 task done

[DocDB] Fatal: Check failed: call #21917

shishir2001-yb opened this issue Apr 11, 2024 · 0 comments
Assignees
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue qa_stress Bugs identified via Stress automation QA QA filed bugs

Comments

@shishir2001-yb
Copy link

shishir2001-yb commented Apr 11, 2024

Jira Link: DB-10833

Description

Version: 2.23.0.0-b146
Logs: https://drive.google.com/file/d/1YdhCVDItoEDHQXt50QWpIsun64RWZiXn/view?usp=sharing

Encountered the below Fatal while running Cross DB DDLs sample app with DDL atomicity

F20240411 06:08:34 ../../src/yb/rpc/rpc.cc:321] Check failed: call 
    @     0xaaaad942113c  google::LogMessage::SendToLog()
    @     0xaaaad9421fe0  google::LogMessage::Flush()
    @     0xaaaad942267c  google::LogMessageFatal::~LogMessageFatal()
    @     0xaaaada650820  yb::rpc::Rpcs::DoRequestAbortAll()
    @     0xaaaada6508ec  yb::rpc::Rpcs::Shutdown()
    @     0xaaaada1a036c  yb::master::PollTransactionStatusBase::Shutdown()
    @     0xaaaada01e990  yb::master::MultiStepMonitoredTask::EndTask()
    @     0xaaaada01ef80  yb::master::MultiStepMonitoredTask::AbortAndReturnPrevState()
    @     0xaaaad9dacae0  yb::master::CatalogEntityWithTasks::AbortTasksAndCloseIfRequested()
    @     0xaaaad9e56444  yb::master::CatalogManager::DeleteTableInMemory()
    @     0xaaaad9e51188  yb::master::CatalogManager::DeleteTableInternal()
    @     0xaaaada19cbf4  yb::master::CatalogManager::YsqlDdlTxnDropTableHelper()
    @     0xaaaada19b724  yb::RunnableImpl<>::Run()
    @     0xaaaadaedeb98  yb::ThreadPool::DispatchThread()
    @     0xaaaadaedb318  yb::Thread::SuperviseThread()
    @     0xffffa75678b8  start_thread
    @     0xffffa75c3afc  thread_start

Test Description:

1. Create a universe with DDL atomicity and Per DB Catalog mode
2. Run cross DB DDL sample app

Also saw the coredump mention in this issue #21877

G-flags:

master_gflags={
                    "ysql_yb_ddl_rollback_enabled": True,
                    "allowed_preview_flags_csv": "ysql_yb_ddl_rollback_enabled",
                    "ysql_transaction_bg_task_wait_ms": ysql_transaction_bg_task_wait_ms,
                    **disable_guradrail_gflags,
                    **config.additional_master_gflags
                },
tserver_gflags={
                    "ysql_yb_ddl_rollback_enabled": True,
                    "allowed_preview_flags_csv": "ysql_yb_ddl_rollback_enabled",
                    # let CM bg task poll for txn status
                    "report_ysql_ddl_txn_status_to_master": report_ysql_ddl_txn_status_to_master,
                    "ysql_catalog_preload_additional_tables": True,
                    "ysql_enable_read_request_caching": True,
                    **disable_guradrail_gflags,
                    **config.additional_tserver_gflags
                }

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@shishir2001-yb shishir2001-yb added area/docdb YugabyteDB core features QA QA filed bugs status/awaiting-triage Issue awaiting triage qa_stress Bugs identified via Stress automation labels Apr 11, 2024
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Apr 11, 2024
@rthallamko3 rthallamko3 removed the status/awaiting-triage Issue awaiting triage label Apr 11, 2024
@rthallamko3 rthallamko3 removed their assignment Apr 11, 2024
@hari90 hari90 closed this as completed in 260b521 Apr 12, 2024
hari90 added a commit that referenced this issue Apr 13, 2024
…atus tasks

Summary:
Original commit: 260b521 / D34045
Add a mutex around creation and assignment of new rpc handles. RPCs should not be shutdown when they have an unassigned rpc handle.
Also make sure `MultiStepMonitoredTask` aborts tasks and waits for inflight steps to complete during `AbortAndReturnPrevState`.

Skip abort of the schema verification tasks during table deletes as we end up aborting our own task.

Fixes #21917
Jira: DB-10833

Test Plan: Jenkins

Reviewers: myang

Reviewed By: myang

Subscribers: ybase

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D34089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue qa_stress Bugs identified via Stress automation QA QA filed bugs
Projects
None yet
Development

No branches or pull requests

4 participants