Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] Disable ParallelAppend in Yugabyte #21934

Closed
1 task done
andrei-mart opened this issue Apr 11, 2024 · 0 comments
Closed
1 task done

[YSQL] Disable ParallelAppend in Yugabyte #21934

andrei-mart opened this issue Apr 11, 2024 · 0 comments
Assignees
@andrei-mart
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@andrei-mart
Copy link
Contributor

andrei-mart commented Apr 11, 2024 •
edited by jira bot
Loading

Jira Link: DB-10849

Description

We disable parallel query by default by preventing parallel YB table scans, but optimizer may choose to run ParallelAppend regardless, since ParallelAppend uses regular scans.
We do not want to expose the feature before GA, and also have seen a number of issues around ParallelAppend.
At the same time we do not want to change the default for Postgres' enable_parallel_append.
Perhaps the best solution is to introduce a new flag to control ParallelAppend on YB tables and eventually change its default to true.

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@andrei-mart andrei-mart added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels Apr 11, 2024
@andrei-mart andrei-mart self-assigned this Apr 11, 2024
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Apr 11, 2024
andrei-mart added a commit that referenced this issue Apr 15, 2024
@andrei-mart
[#21934] YSQL: disable parallel append
d73ae39 
Summary:
To prevent users' exposure to unannounced feature disable parallel
append by introducing new GUC variable yb_enable_parallel_append.

It is pretty much equivalent to Postgres' enable_parallel_append.
Jira: DB-10849

Test Plan:
./yb_build.sh --java-test 'org.yb.pgsql.TestPgRegressParallel'
./yb_build.sh --java-test 'org.yb.pgsql.TestPgRegressJoin'

Reviewers: mtakahara, tnayak

Reviewed By: mtakahara

Subscribers: yql

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D34080
andrei-mart added a commit that referenced this issue Apr 17, 2024
@andrei-mart
[BACKPORT 2024.1][#21934] YSQL: disable parallel append
870e67d 
Summary:
Original commit: d73ae39 / D34080
To prevent users' exposure to unannounced feature disable parallel
append by introducing new GUC variable yb_enable_parallel_append.

It is pretty much equivalent to Postgres' enable_parallel_append.
Jira: DB-10849

Test Plan:
./yb_build.sh --java-test 'org.yb.pgsql.TestPgRegressParallel'
./yb_build.sh --java-test 'org.yb.pgsql.TestPgRegressJoin'

Reviewers: mtakahara, tnayak

Reviewed By: tnayak

Subscribers: yql

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D34128
@yugabyte-ci yugabyte-ci removed the status/awaiting-triage Issue awaiting triage label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrei-mart andrei-mart

Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrei-mart @yugabyte-ci