Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] skip_table_tombstone_check is not set for colocated tables #22115

Closed
1 task done
fizaaluthra opened this issue Apr 23, 2024 · 0 comments
Closed
1 task done

[YSQL] skip_table_tombstone_check is not set for colocated tables #22115

fizaaluthra opened this issue Apr 23, 2024 · 0 comments
Assignees
@fizaaluthra
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue

Comments

@fizaaluthra
Copy link
Contributor

fizaaluthra commented Apr 23, 2024 •
edited by jira bot
Loading

Jira Link: DB-11043

Description

skip_table_tombstone_check is false for colocated tables.

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@fizaaluthra fizaaluthra added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels Apr 23, 2024
@fizaaluthra fizaaluthra self-assigned this Apr 23, 2024
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Apr 23, 2024
@fizaaluthra fizaaluthra added area/docdb YugabyteDB core features and removed area/ysql Yugabyte SQL (YSQL) labels Apr 23, 2024
fizaaluthra added a commit that referenced this issue Apr 23, 2024
@fizaaluthra
[#22115] DocDB: Set skip_table_tombstone_check for colocated tables
da0e6d8 
Summary:
Commit fad94f7 introduces a new tablet metadata field `skip_table_tombstone_check`, but it doesn't set this field for colocated tables. Fix this by setting the field in `AsyncAddTableToTablet()`.

Backport-to: 2024.1
Jira: DB-11043

Test Plan: ./yb_build.sh --cxx-test pgwrapper_pg_mini-test --gtest_filter PgMiniTest.SkipTableTombstoneCheckMetadata

Reviewers: asrivastava

Reviewed By: asrivastava

Subscribers: yql, ybase

Differential Revision: https://phorge.dev.yugabyte.com/D34428
fizaaluthra added a commit that referenced this issue Apr 25, 2024
@fizaaluthra
[BACKPORT 2024.1][#22115] DocDB: Set skip_table_tombstone_check for c…
523cc12 
…olocated tables

Summary:
Commit fad94f7 introduces a new tablet metadata field `skip_table_tombstone_check`, but it doesn't set this field for colocated tables. Fix this by setting the field in `AsyncAddTableToTablet()`.

Backport-to: 2024.1
Jira: DB-11043

Original commit: da0e6d8 / D34428

Test Plan: ./yb_build.sh --cxx-test pgwrapper_pg_mini-test --gtest_filter PgMiniTest.SkipTableTombstoneCheckMetadata

Reviewers: asrivastava

Reviewed By: asrivastava

Subscribers: ybase, yql

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D34436
@sushantrmishra sushantrmishra removed the status/awaiting-triage Issue awaiting triage label Apr 29, 2024
svarnau pushed a commit that referenced this issue May 25, 2024
@fizaaluthra
[#22115] DocDB: Set skip_table_tombstone_check for colocated tables
9c3c769 
Summary:
Commit fad94f7 introduces a new tablet metadata field `skip_table_tombstone_check`, but it doesn't set this field for colocated tables. Fix this by setting the field in `AsyncAddTableToTablet()`.

Backport-to: 2024.1
Jira: DB-11043

Test Plan: ./yb_build.sh --cxx-test pgwrapper_pg_mini-test --gtest_filter PgMiniTest.SkipTableTombstoneCheckMetadata

Reviewers: asrivastava

Reviewed By: asrivastava

Subscribers: yql, ybase

Differential Revision: https://phorge.dev.yugabyte.com/D34428
ZhenYongFan pushed a commit to ZhenYongFan/yugabyte-db that referenced this issue Jun 15, 2024
@fizaaluthra
[BACKPORT 2024.1][yugabyte#22115] DocDB: Set skip_table_tombstone_che…
9a982c4 
…ck for colocated tables

Summary:
Commit fad94f7 introduces a new tablet metadata field `skip_table_tombstone_check`, but it doesn't set this field for colocated tables. Fix this by setting the field in `AsyncAddTableToTablet()`.

Backport-to: 2024.1
Jira: DB-11043

Original commit: da0e6d8 / D34428

Test Plan: ./yb_build.sh --cxx-test pgwrapper_pg_mini-test --gtest_filter PgMiniTest.SkipTableTombstoneCheckMetadata

Reviewers: asrivastava

Reviewed By: asrivastava

Subscribers: ybase, yql

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D34436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fizaaluthra fizaaluthra

Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sushantrmishra @yugabyte-ci @fizaaluthra