Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDCSDK] Allow specifying default replica identity at the time of table creation in a flag #22326

Closed
yugabyte-ci opened this issue May 9, 2024 · 0 comments
Assignees
Labels
2024.1_blocker area/cdcsdk CDC SDK jira-originated kind/enhancement This is an enhancement of an existing feature priority/high High Priority

Comments

@yugabyte-ci
Copy link
Contributor

yugabyte-ci commented May 9, 2024

Jira Link: DB-11234

@yugabyte-ci yugabyte-ci added 2024.1_blocker area/cdcsdk CDC SDK jira-originated kind/enhancement This is an enhancement of an existing feature priority/high High Priority status/awaiting-triage Issue awaiting triage labels May 9, 2024
@yugabyte-ci yugabyte-ci removed the status/awaiting-triage Issue awaiting triage label May 10, 2024
Sumukh-Phalgaonkar added a commit that referenced this issue May 21, 2024
Summary:
This diff adds a tserver flag `ysql_yb_default_replica_identity` which decides the default replica identity for a table at the time of creation. This flag has a default value of "CHANGE". The flag is case sensitive and can take one of these four values "FULL", "DEFAULT", "NOTHING", and "CHANGE. If the flag is assigned any value other than these four, it treats it as an invalid input and the table creation fails.
Jira: DB-11234

Test Plan:
./yb_build.sh --java-test 'org.yb.pgsql.TestPgAlterTable#testReplicaIdentity'
./yb_build.sh --cxx-test pg_mini-test --gtest_filter PgMiniTest.AlterTableWithReplicaIdentity

Reviewers: stiwary, asrinivasan, skumar

Reviewed By: stiwary

Subscribers: yql, ybase, ycdcxcluster

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D34942
svarnau pushed a commit that referenced this issue May 25, 2024
Summary:
This diff adds a tserver flag `ysql_yb_default_replica_identity` which decides the default replica identity for a table at the time of creation. This flag has a default value of "CHANGE". The flag is case sensitive and can take one of these four values "FULL", "DEFAULT", "NOTHING", and "CHANGE. If the flag is assigned any value other than these four, it treats it as an invalid input and the table creation fails.
Jira: DB-11234

Test Plan:
./yb_build.sh --java-test 'org.yb.pgsql.TestPgAlterTable#testReplicaIdentity'
./yb_build.sh --cxx-test pg_mini-test --gtest_filter PgMiniTest.AlterTableWithReplicaIdentity

Reviewers: stiwary, asrinivasan, skumar

Reviewed By: stiwary

Subscribers: yql, ybase, ycdcxcluster

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D34942
svarnau pushed a commit that referenced this issue May 29, 2024
…nfigurable

Summary:
Original commit: 487fb3f / D34942
This diff adds a tserver flag `ysql_yb_default_replica_identity` which decides the default replica identity for a table at the time of creation. This flag has a default value of "CHANGE". The flag is case sensitive and can take one of these four values "FULL", "DEFAULT", "NOTHING", and "CHANGE. If the flag is assigned any value other than these four, it treats it as an invalid input and the table creation fails.

######Backport Description
No merge conflicts were encountered.

Jira: DB-11234

Test Plan:
./yb_build.sh --java-test 'org.yb.pgsql.TestPgAlterTable#testReplicaIdentity'
./yb_build.sh --cxx-test pg_mini-test --gtest_filter PgMiniTest.AlterTableWithReplicaIdentity

Reviewers: stiwary, asrinivasan, skumar, vkushwaha

Reviewed By: vkushwaha

Subscribers: ycdcxcluster, ybase, yql

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D35229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024.1_blocker area/cdcsdk CDC SDK jira-originated kind/enhancement This is an enhancement of an existing feature priority/high High Priority
Projects
None yet
Development

No branches or pull requests

2 participants