Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xCluster] Unify xCluster Stream creation #22343

Closed
1 task done
Tracked by #19714
hari90 opened this issue May 10, 2024 · 0 comments
Closed
1 task done
Tracked by #19714

[xCluster] Unify xCluster Stream creation #22343

hari90 opened this issue May 10, 2024 · 0 comments
Assignees
@hari90
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@hari90
Copy link
Contributor

hari90 commented May 10, 2024 •
edited by jira bot

Jira Link: DB-11249

Description

Remove the option to create an xCluster stream via the cdc_service. This was just forwarding the call to master leader, and used only in TEST code.
Creation of xCluster streams requires custom options to be set on it. This code was scattered across multiple places and there used to be several client function calls. Unified all these into one XClusterClient::CreateXClusterStream.

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@hari90 hari90 added the area/docdb YugabyteDB core features label May 10, 2024
@hari90 hari90 self-assigned this May 10, 2024
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels May 10, 2024
@hari90 hari90 mentioned this issue May 10, 2024
Open
12 tasks
@hari90 hari90 closed this as completed in a2ec883 May 10, 2024
svarnau pushed a commit that referenced this issue May 25, 2024
@hari90
[#22343] xCluster: Unify xCluster Stream creation
99fdbc1 
Summary:
Remove the option to create an xCluster stream via the cdc_service. This was just forwarding the call to master leader, and used only in TEST code.
Creation of xCluster streams requires custom options to be set on it. This code was scattered across multiple places and there used to be several client function calls. Unified all these into one `XClusterClient::CreateXClusterStream<Async>`.
xCluster streams use a static set of options which does not change. So now `XClusterSourceManager` sets these to the correct value. The Client code still sends the same options to make sure we work with older clusters. The client code can be cleaned up in the future

Fixes #22343
Jira: DB-11249

Test Plan: Jenkins

Reviewers: jhe, slingam, xCluster

Reviewed By: jhe

Subscribers: stiwary, skumar, ycdcxcluster, ybase

Differential Revision: https://phorge.dev.yugabyte.com/D34138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hari90 hari90

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hari90 @yugabyte-ci