Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2DC] Lookup tables should do a full name match #2250

Closed
ndeodhar opened this issue Sep 9, 2019 · 0 comments
Closed

[2DC] Lookup tables should do a full name match #2250

ndeodhar opened this issue Sep 9, 2019 · 0 comments
Assignees
@ndeodhar
Labels
area/cdc Change Data Capture kind/bug This issue is a bug
Projects
YBase features

Comments

@ndeodhar
Copy link
Contributor

ndeodhar commented Sep 9, 2019

Given a list of producer table names to replicate, to find matching tables on consumer, we use ListTables API which does a substring match. This results in incorrect matches in situations where the table names have common substrings - for example, sqlsecondaryindex and sqlsecondaryindex_index.

Once we get the results from ListTables, we need to further filter down based on exact name match.
@ndeodhar ndeodhar added kind/bug This issue is a bug area/cdc Change Data Capture labels Sep 9, 2019
@ndeodhar ndeodhar self-assigned this Sep 9, 2019
@ndeodhar ndeodhar added this to To Do in YBase features via automation Sep 9, 2019
ndeodhar added a commit that referenced this issue Sep 10, 2019
@ndeodhar
#2250 [2DC]: Do full table name match while finding matching tables f…
7168e1f 
…or replication

Summary:
Given a list of producer table names to replicate, to find matching tables on consumer, we use `ListTables` API which does a substring match. This results in incorrect matches in situations where the table names have common substrings - for example, `sqlsecondaryindex` and `sqlsecondaryindex_index`.

In this diff, once we get the results from `ListTables`, we further filter down based on exact name match.

Test Plan:
Unit test
Jenkins

Reviewers: rahuldesirazu, nicolas

Reviewed By: nicolas

Subscribers: ybase, bogdan

Differential Revision: https://phabricator.dev.yugabyte.com/D7176
YBase features automation moved this from To Do to Done Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndeodhar ndeodhar

Labels
area/cdc Change Data Capture kind/bug This issue is a bug
Projects
YBase features
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ndeodhar