Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--vmodule is not working #3176

Closed
ttyusupov opened this issue Dec 19, 2019 · 0 comments
Closed

--vmodule is not working #3176

ttyusupov opened this issue Dec 19, 2019 · 0 comments
Assignees
Labels
kind/bug This issue is a bug

Comments

@ttyusupov
Copy link
Contributor

Specifying --vmodule argument does not enable VLOGs.

Here is the patch which fixes the issue:

diff --git a/src/yb/util/status.cc b/src/yb/util/status.cc
index 62194e3b04..25af178c82 100644
--- a/src/yb/util/status.cc
+++ b/src/yb/util/status.cc
@@ -81,8 +81,8 @@ struct StatusCategories {
   void Register(const StatusCategoryDescription& description) {
     CHECK(!categories[description.id].name);
-    VLOG(1) << "Registering status category: " << static_cast<int>(description.id)
-            << " (" << *description.name << ")";
+//    VLOG(1) << "Registering status category: " << static_cast<int>(description.id)
+//            << " (" << *description.name << ")";
     categories[description.id] = description;
   }

The reason is that GLOG --vmodule configuration might break if VLOG is used during global variables initialization.

@ttyusupov ttyusupov added the kind/bug This issue is a bug label Dec 19, 2019
@ttyusupov ttyusupov self-assigned this Dec 19, 2019
@ttyusupov ttyusupov added this to To Do in YBase features via automation Dec 19, 2019
@ttyusupov ttyusupov moved this from To Do to In progress in YBase features Dec 19, 2019
ttyusupov added a commit that referenced this issue Dec 19, 2019
Summary:
GLOG `--vmodule` configuration is not working if `VLOG` is used during global variables initialization.
- Removed `VLOG` from `errno_category_registerer` global variable initialization code path.

Test Plan: Added `LoggingTest.VModule` unit-test.

Reviewers: dmitry, mikhail

Reviewed By: mikhail

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D7717
YBase features automation moved this from In progress to Done Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This issue is a bug
Projects
Development

No branches or pull requests

1 participant