Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YCQL] Add gflag to create tables as transactions enabled by default #3313

Closed
ddorian opened this issue Jan 10, 2020 · 1 comment
Closed

[YCQL] Add gflag to create tables as transactions enabled by default #3313

ddorian opened this issue Jan 10, 2020 · 1 comment
Assignees
@OlegLoginov

Comments

@ddorian
Copy link
Contributor

ddorian commented Jan 10, 2020

Many third party apps create tables & indexes expecting them to work without enabling transactions because that's how Cassandra works by default.

We need to add a gflag to have the same expected functionality as cassandra.
@ddorian ddorian mentioned this issue Jan 10, 2020
Closed
OlegLoginov added a commit that referenced this issue Jan 29, 2020
@OlegLoginov
#3313,#3314,#3315: [YCQL] Add gflag to create CQL tables as transacti…
1040e72 
…onal by default; change GROUP from reserved word to keyword; fix duplicate column error message.

Summary:
Fixed tasks:
#3313: [YCQL] Add gflag to create tables as transactions enabled by default
#3314: [YCQL] Fix reserved words when running queries
#3315: [YCQL] Rename error when adding duplicate column to a table for cassandra compatibility

The fixed tasks are subtasks related to the Kong tool support:
#3178: [YCQL] 'kong migrations bootstrap' fails to create Indexes with Yugabyte.

Test Plan:
ybd --java-test org.yb.cql.TestKeyword#testUnreservedKeyword
ybd --java-test org.yb.cql.TestCreateTable#testCreateTableWithColumnNamedGroup
ybd --java-test org.yb.cql.TestIndex#testCreateIndexWithNonTransactionalTable
ybd --java-test org.yb.cql.TestTransactionalByDefault#testCreateTableAndIndex

Reviewers: alex, neil

Reviewed By: neil

Subscribers: kannan, yql

Differential Revision: https://phabricator.dev.yugabyte.com/D7815
@OlegLoginov
Copy link
Contributor

Fixed by the commit above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlegLoginov OlegLoginov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ddorian @OlegLoginov