Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docdb] yb-admin master_leader_stepdown shouldn't require specifying new leader #4722

Closed
stevebang opened this issue Jun 9, 2020 · 0 comments
Closed

[docdb] yb-admin master_leader_stepdown shouldn't require specifying new leader #4722

stevebang opened this issue Jun 9, 2020 · 0 comments
Assignees
@d-uspenskiy
Labels
area/docdb YugabyteDB core features
Projects
YBase features Usability

Comments

@stevebang
Copy link
Contributor

Both @iSignal and @d-uspenskiy think that the yb-admin master_leader_stepdown command should have new_leader_id as optional.

Source: #4135
@stevebang stevebang added the area/docdb YugabyteDB core features label Jun 9, 2020
@d-uspenskiy d-uspenskiy self-assigned this Jun 9, 2020
@bmatican bmatican changed the title [ybase] yb-admin master_leader_stepdown shouldn't require specifying new leader [docdb] yb-admin master_leader_stepdown shouldn't require specifying new leader Jun 9, 2020
@bmatican bmatican added this to To Do in YBase features via automation Jun 9, 2020
@bmatican bmatican added this to To do in Usability via automation Jun 9, 2020
d-uspenskiy added a commit that referenced this issue Jun 16, 2020
@d-uspenskiy
#4722 [YSQL] Make new_leader_id arg optional for master_leader_stepdo…
1da6988 
…wn yb-admin cmd

Summary: Make `new_leader_id` arg optional for `master_leader_stepdown` yb-admin cmd

Test Plan:
Test case updated
```
./yb_build.sh --cxx-test yb-admin-multi-master-test
```

Reviewers: alex, sanketh

Reviewed By: sanketh

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D8678
YBase features automation moved this from To Do to Done Jun 16, 2020
Usability automation moved this from To do to Done Jun 16, 2020
@aegershman aegershman mentioned this issue Jul 16, 2020
Closed
deeps1991 pushed a commit to deeps1991/yugabyte-db that referenced this issue Jul 22, 2020
@d-uspenskiy @deeps1991
yugabyte#4722 [YSQL] Make new_leader_id arg optional for master_leade…
7ea4c54 
…r_stepdown yb-admin cmd

Summary: Make `new_leader_id` arg optional for `master_leader_stepdown` yb-admin cmd

Test Plan:
Test case updated
```
./yb_build.sh --cxx-test yb-admin-multi-master-test
```

Reviewers: alex, sanketh

Reviewed By: sanketh

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D8678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d-uspenskiy d-uspenskiy

Labels
area/docdb YugabyteDB core features
Projects
Usability
  
Done
YBase features
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevebang @d-uspenskiy