Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Platform] Ability to change the YW user role from the UI #5311

Closed
rao-vasireddy opened this issue Aug 4, 2020 · 1 comment
Closed

[Platform] Ability to change the YW user role from the UI #5311

rao-vasireddy opened this issue Aug 4, 2020 · 1 comment
Assignees
@rao-vasireddy
Labels
kind/enhancement This is an enhancement of an existing feature platform/current
Projects
Platform
Milestone
v2.2.x

Comments

@rao-vasireddy
Copy link
Contributor

rao-vasireddy commented Aug 4, 2020 •
edited by daniel-yb

We will have Admin, ReadOnly and also another role to do readonly + ability to do backups.
This request is to have the ability to change the role of a user from the UI by an admin.
@rao-vasireddy rao-vasireddy added the kind/enhancement This is an enhancement of an existing feature label Aug 4, 2020
@rao-vasireddy rao-vasireddy added this to To do in Platform Aug 4, 2020
@bmatican bmatican assigned sshev and unassigned Arnav15 Aug 4, 2020
@streddy-yb streddy-yb moved this from To do to In progress in Platform Aug 25, 2020
@sshev sshev moved this from In progress to In Review in Platform Sep 4, 2020
sshev added a commit that referenced this issue Sep 8, 2020
@sshev
[YW][#5311] Change user role from UI
4b35731 
Summary:
- change user role from UI
- fix an issue with stale users list after creation/deletion of a user
- disable "save" buttons at customer profile tabs for read-only users
- remove duplicate code

Test Plan:
Run UI, login as **Admin** user, navigate to "/profile/manage-users", click Add User button and see `BackupAdmin` in roles dropdown.
{F14001}

Run UI, login as **Admin** user, navigate to "/profile/manage-users", click Actions button for any existing user and see "Edit User Role" menu item. Clicking on it should show modal allowing to change user role.
{F14003}
{F14004}

Run UI, login as a **read-only** user, navigate to customer profile and see "Save" buttons are disabled for all 3 tabs

Run UI, login as **BackupAdmin** user, open any universe and navigate to  Backups tab - backup action buttons should be available.
{F14005}

Reviewers: andrew

Reviewed By: andrew

Subscribers: rao, cnarang, ui

Differential Revision: https://phabricator.dev.yugabyte.com/D9312
@sshev sshev moved this from In Review to Needs QA/Docs in Platform Sep 8, 2020
@streddy-yb streddy-yb added this to the v2.2.x milestone Sep 10, 2020
@streddy-yb streddy-yb moved this from Needs QA/Docs to In progress in Platform Sep 10, 2020
@sshev sshev moved this from In progress to In Review in Platform Sep 15, 2020
sshev added a commit that referenced this issue Sep 15, 2020
@sshev
[Backport to 2.2][YW][#5311] Change user role from UI
8c90610 
Summary:
- change user role from UI
- fix an issue with stale users list after creation/deletion of a user
- disable "save" buttons at customer profile tabs for read-only users
- remove duplicate code

fix optional chaining

Test Plan:
Run UI, login as **Admin** user, navigate to "/profile/manage-users", click Add User button and see `BackupAdmin` in roles dropdown.
{F14001}

Run UI, login as **Admin** user, navigate to "/profile/manage-users", click Actions button for any existing user and see "Edit User Role" menu item. Clicking on it should show modal allowing to change user role.
{F14003}
{F14004}

Run UI, login as a **read-only** user, navigate to customer profile and see "Save" buttons are disabled for all 3 tabs

Run UI, login as **BackupAdmin** user, open any universe and navigate to  Backups tab - backup action buttons should be available.
{F14005}

Reviewers: andrew

Reviewed By: andrew

Subscribers: ui, cnarang, rao

Differential Revision: https://phabricator.dev.yugabyte.com/D9385
@sshev sshev moved this from In Review to Needs QA/Docs in Platform Sep 15, 2020
@sshev sshev assigned rao-vasireddy and unassigned sshev Sep 15, 2020
@sshev
Copy link
Collaborator

sshev commented Sep 15, 2020

Backported to 2.2

@streddy-yb streddy-yb moved this from Needs QA/Docs to Done in Platform Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rao-vasireddy rao-vasireddy

Labels
kind/enhancement This is an enhancement of an existing feature platform/current
Projects
Platform
  
Closed
Milestone
v2.2.x
Development

No branches or pull requests
4 participants
@sshev @Arnav15 @rao-vasireddy @streddy-yb