Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Platform] backup script needs to preserve attributes on copy from prometheus snapshot #5612

Closed
ajcaldera1 opened this issue Sep 8, 2020 · 1 comment
Closed

[Platform] backup script needs to preserve attributes on copy from prometheus snapshot #5612

ajcaldera1 opened this issue Sep 8, 2020 · 1 comment
Assignees
@WesleyW @chirag-yb
Labels
area/platform Yugabyte Platform
Projects
Platform
Milestone
v2.2.x

Comments

@ajcaldera1
Copy link
Contributor

When copying the snapshot from the prometheus directory -- we should maintain file attributes (such as permissions/ownership). Add -a option to the cp command to do this.
@ajcaldera1 ajcaldera1 added the area/platform Yugabyte Platform label Sep 8, 2020
@streddy-yb streddy-yb added this to the v2.2.x milestone Sep 8, 2020
@streddy-yb streddy-yb added this to To do in Platform Sep 8, 2020
@streddy-yb
Copy link
Contributor

Change:
sudo cp -R $PROMETHEUS_DATA_DIR/snapshots/$snapshot_dir $data_dir/prometheus_snapshot
TO:
sudo cp -aR $PROMETHEUS_DATA_DIR/snapshots/$snapshot_dir $data_dir/prometheus_snapshot

@streddy-yb streddy-yb moved this from To do to In progress in Platform Sep 8, 2020
@streddy-yb streddy-yb moved this from In progress to In Review in Platform Sep 10, 2020
WesleyW added a commit that referenced this issue Sep 15, 2020
@WesleyW
Add docker- and vm-aware options to YW backup script #5120, #5615, #5612
7af68f4 
, #5614

Summary: YW backup script is now aware of docker/vm environment and will do prometheus snapshots.

Test Plan: take snnapshot and restore on Replicated-based and VM-based

Reviewers: rahuldesirazu, sanketh

Reviewed By: sanketh

Subscribers: jenkins-bot, yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D9165
@streddy-yb streddy-yb moved this from In Review to Needs QA/Docs in Platform Sep 28, 2020
@streddy-yb streddy-yb moved this from Needs QA/Docs to Done in Platform Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WesleyW WesleyW

@chirag-yb chirag-yb

Labels
area/platform Yugabyte Platform
Projects
Platform
  
Closed
Milestone
v2.2.x
Development

No branches or pull requests
4 participants
@WesleyW @ajcaldera1 @chirag-yb @streddy-yb