[docdb] BackupTxnTest.Consistency started being more flaky in master recently #5788
Assignees
Labels
Projects
Comments
bmatican
added
kind/failing-test
spolitov
added a commit
that referenced
this issue
Oct 12, 2020
… metadata when restoring a snapshot Summary: When ModifyFlushedFrontier is called on RocksDB it could erase user frontiers for SST files. So hybrid time filter could be lost and restored snapshot would be inconsistent. We should only erase the OpId frontier for each SSTable file in that case, and leave other types of frontiers (such as hybrid time filters) intact. Also fixing a bug with transaction apply. It should create a ScopedRWOperation to avoid a situation when we start applying a transaction before restoring a backup, and we end up applying intents of an unrelated transaction to a restored regular RocksDB. Also clearing running transactions in TransactionParticipant when performing a TRUNCATE operation or restoring a snapshot. Test Plan: ybd --gtest_filter BackupTxnTest.Consistency -n 20 Reviewers: mikhail Reviewed By: mikhail Subscribers: bogdan, ybase Differential Revision: https://phabricator.dev.yugabyte.com/D9561
spolitov
added a commit
that referenced
this issue
Oct 22, 2020
…d from per-SSTable metadata when restoring a snapshot Summary: When ModifyFlushedFrontier is called on RocksDB it could erase user frontiers for SST files. So hybrid time filter could be lost and restored snapshot would be inconsistent. We should only erase the OpId frontier for each SSTable file in that case, and leave other types of frontiers (such as hybrid time filters) intact. Also fixing a bug with transaction apply. It should create a ScopedRWOperation to avoid a situation when we start applying a transaction before restoring a backup, and we end up applying intents of an unrelated transaction to a restored regular RocksDB. Also clearing running transactions in TransactionParticipant when performing a TRUNCATE operation or restoring a snapshot. Test Plan: ybd --gtest_filter BackupTxnTest.Consistency -n 20 Jenkins: rebase: 2.2 Reviewers: mikhail, bogdan Reviewed By: bogdan Subscribers: ybase, bogdan Differential Revision: https://phabricator.dev.yugabyte.com/D9684
spolitov
added a commit
that referenced
this issue
Oct 24, 2020
…d from per-SSTable metadata when restoring a snapshot Summary: When ModifyFlushedFrontier is called on RocksDB it could erase user frontiers for SST files. So hybrid time filter could be lost and restored snapshot would be inconsistent. We should only erase the OpId frontier for each SSTable file in that case, and leave other types of frontiers (such as hybrid time filters) intact. Also fixing a bug with transaction apply. It should create a ScopedRWOperation to avoid a situation when we start applying a transaction before restoring a backup, and we end up applying intents of an unrelated transaction to a restored regular RocksDB. Also clearing running transactions in TransactionParticipant when performing a TRUNCATE operation or restoring a snapshot. Test Plan: ybd --gtest_filter BackupTxnTest.Consistency -n 20 Jenkins: rebase: 2.1 Reviewers: mikhail, bogdan Reviewed By: bogdan Subscribers: bogdan, ybase Differential Revision: https://phabricator.dev.yugabyte.com/D9702
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://detective-gcp.dev.yugabyte.com/stability/test?buckets=30&class=BackupTxnTest&name=Consistency
This seems to point towards this range: 6f00b05~...90be7c9
Only docdb change in the list is 1b5e70d
The text was updated successfully, but these errors were encountered: