Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[platform] Enable CORS policy by default #6390

Closed
streddy-yb opened this issue Nov 17, 2020 · 0 comments
Closed

[platform] Enable CORS policy by default #6390

streddy-yb opened this issue Nov 17, 2020 · 0 comments
Assignees
Labels
area/platform Yugabyte Platform
Projects
Milestone

Comments

@streddy-yb
Copy link
Contributor

No description provided.

@streddy-yb streddy-yb added the area/platform Yugabyte Platform label Nov 17, 2020
@streddy-yb streddy-yb added this to the 2.4.0.0 milestone Nov 17, 2020
@streddy-yb streddy-yb added this to To do in Platform Nov 17, 2020
@SergeyPotachev SergeyPotachev moved this from To do to In progress in Platform Nov 30, 2020
@streddy-yb streddy-yb changed the title [platform] Disable CORS policy by default [platform] Enable CORS policy by default Nov 30, 2020
@daniel-yb daniel-yb moved this from In progress to In Review in Platform Dec 11, 2020
daniel-yb added a commit that referenced this issue Dec 11, 2020
Summary: Enable CORS policy in our replicated deployments. These changes will have to be made for our other deployment models as well.

Test Plan: Manually change the application.conf file to have the values in this diff for GCP portal, and verify that while requests coming from the correct origin work, requests coming from some other origin (i.e. the IP addr of the VM) are blocked by the CORS policy.

Reviewers: spotachev, sanketh

Reviewed By: sanketh

Subscribers: streddy, jenkins-bot, yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D10101
daniel-yb added a commit that referenced this issue Dec 11, 2020
Summary: Enable CORS policy in our replicated deployments. These changes will have to be made for our other deployment models as well.

Test Plan: Manually change the application.conf file to have the values in this diff for GCP portal, and verify that while requests coming from the correct origin work, requests coming from some other origin (i.e. the IP addr of the VM) are blocked by the CORS policy.

Reviewers: sanketh, spotachev

Reviewed By: spotachev

Subscribers: yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D10109
@daniel-yb daniel-yb moved this from In Review to Done in Platform Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform Yugabyte Platform
Projects
Platform
  
Closed
Development

No branches or pull requests

3 participants