Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YCQL] Mark connection as unusable if authentication failed #6608

Closed
m-iancu opened this issue Dec 10, 2020 · 0 comments
Closed

[YCQL] Mark connection as unusable if authentication failed #6608

m-iancu opened this issue Dec 10, 2020 · 0 comments
Assignees
@m-iancu @OlegLoginov

Comments

@m-iancu
Copy link
Contributor

m-iancu commented Dec 10, 2020

No description provided.

m-iancu pushed a commit that referenced this issue Dec 10, 2020
@OlegLoginov @m-iancu
[#6608, #6609] YCQL: Consolidate authentication error handling and me…
2145d3a 
…ssages

Summary:
#6608 Mark connection as unusable if authentication failed
For consistency, if authentication is used (i.e. the flag `--use_cassandra_authentication` is set)
and authentication step fails we mark that connection as unusable.

#6609: Ensure consistent error messages for authentication failure.
Error messages for bad user name and bad password are identical now.

Test Plan:
ybd --cxx-test cqlserver-test --gtest-filter TestCQLServiceWithCassAuth.TestReadSystemTable
ybd --cxx-test cqlserver-test --gtest-filter TestCQLServiceWithCassAuth.TestReadSystemTableNotAuthenticated
ybd --cxx-test cqlserver-test --gtest-filter TestCQLServiceWithCassAuth.TestReadSystemTableAuthenticated

Reviewers: neil, oleg

Reviewed By: neil, oleg

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D9782
@m-iancu m-iancu closed this as completed Dec 10, 2020
m-iancu pushed a commit that referenced this issue Dec 10, 2020
@OlegLoginov @m-iancu
[Backport 2.4][#6608, #6609] YCQL: Consolidate authentication error h…
197ff6c 
…andling and messages

Summary:
#6608 Mark connection as unusable if authentication failed
For consistency, if authentication is used (i.e. the flag `--use_cassandra_authentication` is set)
and authentication step fails we mark that connection as unusable.

#6609: Ensure consistent error messages for authentication failure.
Error messages for bad user name and bad password are identical now.

Test Plan:
Jenkins: rebase: 2.4
ybd --cxx-test cqlserver-test --gtest-filter TestCQLServiceWithCassAuth.TestReadSystemTable
ybd --cxx-test cqlserver-test --gtest-filter TestCQLServiceWithCassAuth.TestReadSystemTableNotAuthenticated
ybd --cxx-test cqlserver-test --gtest-filter TestCQLServiceWithCassAuth.TestReadSystemTableAuthenticated

Reviewers: neil, oleg

Reviewed By: oleg

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D10094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-iancu m-iancu

@OlegLoginov OlegLoginov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@m-iancu @OlegLoginov