You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Noah mentioned the following commit under the thread 'Alter timestamp without timezone to with timezone rewrites rows':
Avoid some table rewrites for ALTER TABLE .. SET DATA TYPE timestamp
When the timezone is UTC, timestamptz and timestamp are binary coercible
in both directions. See b8a18ad4850ea5ad7884aa6ab731fd392e73b4ad and
c22ecc6562aac895f0f0529707d7bdb460fd2a49 for the previous attempt in
this problem space. Skip the table rewrite; for now, continue to
needlessly rewrite any index on an affected column.
Reviewed by Simon Riggs and Tom Lane.
Discussion: https://postgr.es/m/20190226061450.GA1665944@rfd.leadboat.com
We should backport this enhancement.
The text was updated successfully, but these errors were encountered:
…SET DATA TYPE timestamp'
Summary:
Noah mentioned the following commit under the thread 'Alter timestamp without timezone to with timezone rewrites rows' (commit hash 3c5926301aea476025f118159688a6a88b2738bc)
Here is the link to the thread:
https://www.postgresql.org/message-id/20210116115342.GA1681052%40rfd.leadboat.com
Avoid some table rewrites for ALTER TABLE .. SET DATA TYPE timestamp
```
When the timezone is UTC, timestamptz and timestamp are binary coercible
in both directions. See b8a18ad4850ea5ad7884aa6ab731fd392e73b4ad and
c22ecc6562aac895f0f0529707d7bdb460fd2a49 for the previous attempt in
this problem space. Skip the table rewrite; for now, continue to
needlessly rewrite any index on an affected column.
Reviewed by Simon Riggs and Tom Lane.
Discussion: https://postgr.es/m/20190226061450.GA1665944@rfd.leadboat.com
```
This revision backports the patch.
Related code in ybccmds.c is modified to allow timestamp <-> timestamptz type change when no rewrite is needed.
Test Plan: Run org.yb.pgsql.TestPgRegressTrigger#testPgRegressTrigger which passes with the change.
Reviewers: jason, ena
Reviewed By: jason
Subscribers: yql
Differential Revision: https://phabricator.dev.yugabyte.com/D10381
…ABLE .. SET DATA TYPE timestamp'
Summary:
Noah mentioned the following commit under the thread 'Alter timestamp without timezone to with timezone rewrites rows' (commit hash 3c5926301aea476025f118159688a6a88b2738bc)
Here is the link to the thread:
https://www.postgresql.org/message-id/20210116115342.GA1681052%40rfd.leadboat.com
Avoid some table rewrites for ALTER TABLE .. SET DATA TYPE timestamp
```
When the timezone is UTC, timestamptz and timestamp are binary coercible
in both directions. See b8a18ad4850ea5ad7884aa6ab731fd392e73b4ad and
c22ecc6562aac895f0f0529707d7bdb460fd2a49 for the previous attempt in
this problem space. Skip the table rewrite; for now, continue to
needlessly rewrite any index on an affected column.
Reviewed by Simon Riggs and Tom Lane.
Discussion: https://postgr.es/m/20190226061450.GA1665944@rfd.leadboat.com
```
This revision backports the patch.
Related code in ybccmds.c is modified to allow timestamp <-> timestamptz type change when no rewrite is needed.
Test Plan: Run org.yb.pgsql.TestPgRegressTrigger#testPgRegressTrigger which passes with the change.
Reviewers: jason, ena
Reviewed By: jason
Subscribers: yql
Differential Revision: https://phabricator.dev.yugabyte.com/D10381
Noah mentioned the following commit under the thread 'Alter timestamp without timezone to with timezone rewrites rows':
Avoid some table rewrites for ALTER TABLE .. SET DATA TYPE timestamp
We should backport this enhancement.
The text was updated successfully, but these errors were encountered: