[Platform] Changing node filter for universe metrics does not update the graphs #7107
Assignees
Labels
Projects
Comments
andrewc-dev
added
area/ui
|
This issue also affects 2.4.0 |
sunilsutarDCE
added a commit
that referenced
this issue
Feb 18, 2021
…update the graphs Summary: 1) On universe -> Metrics tab, when changing the node filter from 'All' to a specific nodes, then back. Sometimes the graph will not re-plot even though the data is different. There was a condition added to prevent re-plotting of graph for time on componentDidUpdate lifecycle method , but need to check values as well when node changed . So deep comparing on the x-axis and y-axis data arrays. 2) While testing also found that - when node select it was not showing as selected in dropdown, currentSelectedNode state was not updated when node dropdown changed . Test Plan: - Run UI - Go to Metrics navigation link at left side or universe -> Metrics tab - Try changing Universe and selecting node . - Checked manually by debugging in google developers tool for re-plotting graph Reviewers: mjoshi, andrew Reviewed By: andrew Subscribers: sshevchenko, ui, yugaware Differential Revision: https://phabricator.dev.yugabyte.com/D10629
polarweasel
pushed a commit
to lizayugabyte/yugabyte-db
that referenced
this issue
Mar 9, 2021
…oes not update the graphs Summary: 1) On universe -> Metrics tab, when changing the node filter from 'All' to a specific nodes, then back. Sometimes the graph will not re-plot even though the data is different. There was a condition added to prevent re-plotting of graph for time on componentDidUpdate lifecycle method , but need to check values as well when node changed . So deep comparing on the x-axis and y-axis data arrays. 2) While testing also found that - when node select it was not showing as selected in dropdown, currentSelectedNode state was not updated when node dropdown changed . Test Plan: - Run UI - Go to Metrics navigation link at left side or universe -> Metrics tab - Try changing Universe and selecting node . - Checked manually by debugging in google developers tool for re-plotting graph Reviewers: mjoshi, andrew Reviewed By: andrew Subscribers: sshevchenko, ui, yugaware Differential Revision: https://phabricator.dev.yugabyte.com/D10629
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On universe -> Metrics tab, when changing the node filter from 'All' to a specific nodes, then back. Sometimes the graph will not re-plot even though the data is different.
EDIT: Seen on version 2.5.2
The text was updated successfully, but these errors were encountered: