Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Platform UI] Disable Read Replicas for Kubernetes #7437

Closed
Arnav15 opened this issue Mar 2, 2021 · 0 comments
Closed

[Platform UI] Disable Read Replicas for Kubernetes #7437

Arnav15 opened this issue Mar 2, 2021 · 0 comments
Assignees
@mjoshi0923
Labels
area/kubernetes Kubernetes support and deployments. area/platform Yugabyte Platform
Projects
Platform
Milestone
2.5.x

Comments

@Arnav15
Copy link
Contributor

Arnav15 commented Mar 2, 2021

Since k8s currently doesn't support read replicas, we should disable it from the UI. Also, we shouldn't show k8s providers when configuring a read-replica.
@Arnav15 Arnav15 added area/kubernetes Kubernetes support and deployments. area/platform Yugabyte Platform labels Mar 2, 2021
@streddy-yb streddy-yb added this to To do in Platform Mar 8, 2021
@streddy-yb streddy-yb added this to the 2.5.x milestone Mar 8, 2021
@Arnav15 Arnav15 moved this from To do to In Review in Platform Mar 16, 2021
mjoshi0923 added a commit that referenced this issue Mar 22, 2021
@mjoshi0923
[#7437][Platform] Disable Read Replicas for Kubernetes
0767a8e 
Summary: Since k8s currently doesn't support read replicas, we should disable it from the UI. Also, we shouldn't show k8s providers when configuring a read-replica.

Test Plan:
Pointed portal to http://portal.k8s-24.dev.yugabyte.com/ to check how **create universe **looks when provider is k8s and checked with http://portal.dev.yugabyte.com/ to see is there is any regression on non k8s providers.

{F15388}
Also we are hiding **add read replica** from universe actions
{F15389}

Reviewers: andrew, ssutar, sshevchenko

Reviewed By: sshevchenko

Subscribers: yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D10868
@mjoshi0923 mjoshi0923 moved this from In Review to Closed in Platform Mar 31, 2021
@mjoshi0923 mjoshi0923 moved this from Closed to Needs QA/Docs in Platform Apr 6, 2021
YintongMa pushed a commit to YintongMa/yugabyte-db that referenced this issue May 26, 2021
@mjoshi0923 @YintongMa
[yugabyte#7437][Platform] Disable Read Replicas for Kubernetes
b96aa49 
Summary: Since k8s currently doesn't support read replicas, we should disable it from the UI. Also, we shouldn't show k8s providers when configuring a read-replica.

Test Plan:
Pointed portal to http://portal.k8s-24.dev.yugabyte.com/ to check how **create universe **looks when provider is k8s and checked with http://portal.dev.yugabyte.com/ to see is there is any regression on non k8s providers.

{F15388}
Also we are hiding **add read replica** from universe actions
{F15389}

Reviewers: andrew, ssutar, sshevchenko

Reviewed By: sshevchenko

Subscribers: yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D10868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjoshi0923 mjoshi0923

Labels
area/kubernetes Kubernetes support and deployments. area/platform Yugabyte Platform
Projects
Platform
  
Needs QA/Docs
Milestone
2.5.x
Development

No branches or pull requests
3 participants
@Arnav15 @streddy-yb @mjoshi0923