[Platform] Slow queries are being fetched too often #7624
Assignees
Labels
Projects
Comments
andrewc-dev
pushed a commit
that referenced
this issue
Mar 16, 2021
Summary: Slow query api call is taking a long time, around 630ms, so we can reduce CPU consumption by reducing the number of times slow queries are fetched. Remove refetching on window focus and add stale time to data so we don't fetch if user navigates to a different page then back. Test Plan: Open universe overview tab and then navigate to slow query tab, confirm that the slow queries are only fetched once. Confirm when clicking out of window then clicking into the window does not trigger a refetch of slow_queries. Reviewers: mjoshi, ssutar, sshevchenko Reviewed By: sshevchenko Subscribers: ui Differential Revision: https://phabricator.dev.yugabyte.com/D10906
andrewc-dev
pushed a commit
that referenced
this issue
Mar 19, 2021
…ries. Summary: Slow query api call is taking a long time, around 630ms, so we can reduce CPU consumption by reducing the number of times slow queries are fetched. Remove refetching on window focus and add stale time to data so we don't fetch if user navigates to a different page then back. Test Plan: Open universe overview tab and then navigate to slow query tab, confirm that the slow queries are only fetched once. Confirm when clicking out of window then clicking into the window does not trigger a refetch of slow_queries. Reviewers: mjoshi, ssutar, sshevchenko Reviewed By: sshevchenko Subscribers: ui Differential Revision: https://phabricator.dev.yugabyte.com/D10906
YintongMa
pushed a commit
to YintongMa/yugabyte-db
that referenced
this issue
May 26, 2021
Summary: Slow query api call is taking a long time, around 630ms, so we can reduce CPU consumption by reducing the number of times slow queries are fetched. Remove refetching on window focus and add stale time to data so we don't fetch if user navigates to a different page then back. Test Plan: Open universe overview tab and then navigate to slow query tab, confirm that the slow queries are only fetched once. Confirm when clicking out of window then clicking into the window does not trigger a refetch of slow_queries. Reviewers: mjoshi, ssutar, sshevchenko Reviewed By: sshevchenko Subscribers: ui Differential Revision: https://phabricator.dev.yugabyte.com/D10906
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Slow queries are being refetched on window focus. Since the api call is significantly slower than most api calls (at 630ms). Let's remove the refetch on focus that is provided from react-query.
The text was updated successfully, but these errors were encountered: