Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] Import Forbid marking an identity column as nullable. #7682

Closed
tedyu opened this issue Mar 16, 2021 · 0 comments
Closed

[YSQL] Import Forbid marking an identity column as nullable. #7682

tedyu opened this issue Mar 16, 2021 · 0 comments
Projects
Postgres imports

Comments

@tedyu
Copy link
Contributor

tedyu commented Mar 16, 2021

Commit was 6c34f186c4c62ac93b8f5f7229b03301b02741c9

GENERATED ALWAYS AS IDENTITY implies NOT NULL, but the code failed
to complain if you overrode that with "GENERATED ALWAYS AS IDENTITY
NULL".  One might think the old behavior was a feature, but it was
inconsistent because the outcome varied depending on the order of
the clauses, so it seems to have been just an oversight.

Per bug #16913 from Pavel Boev.  Back-patch to v10 where identity
columns were introduced.

Vik Fearing (minor tweaks by me)

Discussion: https://postgr.es/m/16913-3b5198410f67d8c6@postgresql.org
@jaki jaki added this to To do in Postgres imports via automation Mar 16, 2021
@jaki jaki moved this from To do to In progress in Postgres imports Mar 16, 2021
tedyu added a commit that referenced this issue Mar 16, 2021
@tedyu
[#7682] ysql: Import Forbid marking an identity column as nullable.
1f42fca 
Summary:
Commit was 6c34f186c4c62ac93b8f5f7229b03301b02741c9

Commit message was:
```
GENERATED ALWAYS AS IDENTITY implies NOT NULL, but the code failed
to complain if you overrode that with "GENERATED ALWAYS AS IDENTITY
NULL".  One might think the old behavior was a feature, but it was
inconsistent because the outcome varied depending on the order of
the clauses, so it seems to have been just an oversight.

Per bug #16913 from Pavel Boev.  Back-patch to v10 where identity
columns were introduced.

Vik Fearing (minor tweaks by me)

Discussion: https://postgr.es/m/16913-3b5198410f67d8c6@postgresql.org
```

Test Plan:
Build yugabyte DB and run test suite via Jenkins

Run TestPgRegressPgMiscIndependent which covers yb_pg_identity

Reviewers: jason

Reviewed By: jason

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D10947
@tedyu tedyu closed this as completed Mar 16, 2021
Postgres imports automation moved this from In progress to Done Mar 16, 2021
YintongMa pushed a commit to YintongMa/yugabyte-db that referenced this issue May 26, 2021
@tedyu @YintongMa
[yugabyte#7682] ysql: Import Forbid marking an identity column as nul…
4b26be3 
…lable.

Summary:
Commit was 6c34f186c4c62ac93b8f5f7229b03301b02741c9

Commit message was:
```
GENERATED ALWAYS AS IDENTITY implies NOT NULL, but the code failed
to complain if you overrode that with "GENERATED ALWAYS AS IDENTITY
NULL".  One might think the old behavior was a feature, but it was
inconsistent because the outcome varied depending on the order of
the clauses, so it seems to have been just an oversight.

Per bug yugabyte#16913 from Pavel Boev.  Back-patch to v10 where identity
columns were introduced.

Vik Fearing (minor tweaks by me)

Discussion: https://postgr.es/m/16913-3b5198410f67d8c6@postgresql.org
```

Test Plan:
Build yugabyte DB and run test suite via Jenkins

Run TestPgRegressPgMiscIndependent which covers yb_pg_identity

Reviewers: jason

Reviewed By: jason

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D10947
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Postgres imports
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tedyu