Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] Close ifstream when read operation is done #9072

Closed
tedyu opened this issue Jun 23, 2021 · 0 comments
Closed

[YSQL] Close ifstream when read operation is done #9072

tedyu opened this issue Jun 23, 2021 · 0 comments
Assignees
@tedyu

Comments

@tedyu
Copy link
Contributor

tedyu commented Jun 23, 2021

In WritePostgresConfig() and PgSupervisor::CleanupOldServerUnlocked(), we should close the ifstream when read operation is done.
tedyu added a commit that referenced this issue Jun 30, 2021
@tedyu
[#9072] ysql: Close ifstream when read operation is done
b2b5211 
Summary: In WritePostgresConfig() and PgSupervisor::CleanupOldServerUnlocked(), we should close the ifstream when read operation is done.

Test Plan: Build Yugabyte DB and verify there is no test regression.

Reviewers: alex

Reviewed By: alex

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D12056
@tedyu tedyu closed this as completed Jul 1, 2021
@tedyu tedyu self-assigned this Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tedyu tedyu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tedyu